i2c: mux: demux-pinctrl: fix OF node leak on kstrdup failure

[PATCH] i2c: mux: demux-pinctrl: fix OF node leak on kstrdup failure

Posted by Linkai Gong 1 month, 2 weeks ago

of_parse_phandle() takes a reference on the parent node. If a later
devm_kstrdup() fails, err_rollback only releases nodes for indices
0..i-1, so the current node is leaked.

of_node_put() the current parent before rolling back.

Fixes: 7c0195fa9a9e ("i2c: mux: demux-pinctrl: check the return value of devm_kstrdup()")
Signed-off-by: Linkai Gong <gonglinkai@kylinos.cn>
---
 drivers/i2c/muxes/i2c-demux-pinctrl.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/muxes/i2c-demux-pinctrl.c b/drivers/i2c/muxes/i2c-demux-pinctrl.c
index f2a1f4744978..2403c0bf7c43 100644
--- a/drivers/i2c/muxes/i2c-demux-pinctrl.c
+++ b/drivers/i2c/muxes/i2c-demux-pinctrl.c
@@ -247,6 +247,7 @@ static int i2c_demux_pinctrl_probe(struct platform_device *pdev)
 		props[i].value = devm_kstrdup(&pdev->dev, "ok", GFP_KERNEL);
 		if (!props[i].name || !props[i].value) {
 			err = -ENOMEM;
+			of_node_put(adap_np);
 			goto err_rollback;
 		}
 		props[i].length = 3;
-- 
2.25.1

Re: [PATCH] i2c: mux: demux-pinctrl: fix OF node leak on kstrdup failure

Posted by Andi Shyti 1 month, 1 week ago

Hi Linkai,

On Thu, Aug 13, 2026 at 05:56:17PM +0800, Linkai Gong wrote:
> of_parse_phandle() takes a reference on the parent node. If a later
> devm_kstrdup() fails, err_rollback only releases nodes for indices
> 0..i-1, so the current node is leaked.
> 
> of_node_put() the current parent before rolling back.
> 
> Fixes: 7c0195fa9a9e ("i2c: mux: demux-pinctrl: check the return value of devm_kstrdup()")
> Signed-off-by: Linkai Gong <gonglinkai@kylinos.cn>

merged to i2c/i2c-2.

Thanks,
Andi