i3c: dw: use COMMAND_PORT_TRANSFER_ARG instead of hardcoding

[PATCH] i3c: dw: use COMMAND_PORT_TRANSFER_ARG instead of hardcoding

Posted by Jisheng Zhang 1 month, 2 weeks ago

Use the well defined COMMAND_PORT_TRANSFER_ARG macro instead of
hardcoding '1'.

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
 drivers/i3c/master/dw-i3c-master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
index 655693a2187e..6ba84a97765f 100644
--- a/drivers/i3c/master/dw-i3c-master.c
+++ b/drivers/i3c/master/dw-i3c-master.c
@@ -876,7 +876,7 @@ static int dw_i3c_master_daa(struct i3c_master_controller *m)
 		goto rpm_out;
 	}
 	cmd = &xfer->cmds[0];
-	cmd->cmd_hi = 0x1;
+	cmd->cmd_hi = COMMAND_PORT_TRANSFER_ARG;
 	cmd->cmd_lo = COMMAND_PORT_DEV_COUNT(master->maxdevs - pos) |
 		      COMMAND_PORT_DEV_INDEX(pos) |
 		      COMMAND_PORT_CMD(I3C_CCC_ENTDAA) |
-- 
2.51.0

Re: [PATCH] i3c: dw: use COMMAND_PORT_TRANSFER_ARG instead of hardcoding

Posted by Alexandre Belloni 1 month, 1 week ago

On Thu, 13 Aug 2026 12:42:25 +0800, Jisheng Zhang wrote:
> Use the well defined COMMAND_PORT_TRANSFER_ARG macro instead of
> hardcoding '1'.

Applied, thanks!

[1/1] i3c: dw: use COMMAND_PORT_TRANSFER_ARG instead of hardcoding
      https://git.kernel.org/i3c/c/942e9a5b676e

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH] i3c: dw: use COMMAND_PORT_TRANSFER_ARG instead of hardcoding

Posted by Frank Li 1 month, 2 weeks ago

On Thu, Aug 13, 2026 at 12:42:25PM +0800, Jisheng Zhang wrote:
> Use the well defined COMMAND_PORT_TRANSFER_ARG macro instead of
> hardcoding '1'.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/i3c/master/dw-i3c-master.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index 655693a2187e..6ba84a97765f 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -876,7 +876,7 @@ static int dw_i3c_master_daa(struct i3c_master_controller *m)
>  		goto rpm_out;
>  	}
>  	cmd = &xfer->cmds[0];
> -	cmd->cmd_hi = 0x1;
> +	cmd->cmd_hi = COMMAND_PORT_TRANSFER_ARG;
>  	cmd->cmd_lo = COMMAND_PORT_DEV_COUNT(master->maxdevs - pos) |
>  		      COMMAND_PORT_DEV_INDEX(pos) |
>  		      COMMAND_PORT_CMD(I3C_CCC_ENTDAA) |
> --
> 2.51.0
>