ASoC: SDCA: Add stub for sdca_fdl_free_state()

[PATCH] ASoC: SDCA: Add stub for sdca_fdl_free_state()

Posted by yaolu@kylinos.cn 1 month, 2 weeks ago

From: Lu Yao <yaolu@kylinos.cn>

Commit 0880082c27b6 ("ASoC: SDCA: Remove devm from primary IRQ
cleanup") added a call to sdca_fdl_free_state() in sdca_interrupts.c,
but only declared it in the CONFIG_SND_SOC_SDCA_FDL enabled section of
sdca_fdl.h. Building SDCA IRQ support without FDL support therefore
fails with:

  sound/soc/sdca/sdca_interrupts.c:471:56: error: 'sdca_fdl_free_state' undeclared (first use in this function); did you mean 'sdca_jack_free_state'?

Fixes: 0880082c27b6 ("ASoC: SDCA: Remove devm from primary IRQ cleanup")
Signed-off-by: Lu Yao <yaolu@kylinos.cn>
Reported-by: k2ci <kernel-bot@kylinos.cn>
---
 include/sound/sdca_fdl.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/sound/sdca_fdl.h b/include/sound/sdca_fdl.h
index dc33927b82bd..bc3600cdd2ec 100644
--- a/include/sound/sdca_fdl.h
+++ b/include/sound/sdca_fdl.h
@@ -83,6 +83,10 @@ static inline int sdca_fdl_alloc_state(struct sdca_interrupt *interrupt)
 	return 0;
 }
 
+static inline void sdca_fdl_free_state(struct sdca_interrupt *interrupt)
+{
+}
+
 static inline int sdca_fdl_process(struct sdca_interrupt *interrupt)
 {
 	return 0;
-- 
2.25.1

Re: [PATCH] ASoC: SDCA: Add stub for sdca_fdl_free_state()

Posted by Charles Keepax 1 month, 2 weeks ago

On Thu, Aug 13, 2026 at 09:26:36AM +0800, yaolu@kylinos.cn wrote:
> From: Lu Yao <yaolu@kylinos.cn>
> 
> Commit 0880082c27b6 ("ASoC: SDCA: Remove devm from primary IRQ
> cleanup") added a call to sdca_fdl_free_state() in sdca_interrupts.c,
> but only declared it in the CONFIG_SND_SOC_SDCA_FDL enabled section of
> sdca_fdl.h. Building SDCA IRQ support without FDL support therefore
> fails with:
> 
>   sound/soc/sdca/sdca_interrupts.c:471:56: error: 'sdca_fdl_free_state' undeclared (first use in this function); did you mean 'sdca_jack_free_state'?
> 
> Fixes: 0880082c27b6 ("ASoC: SDCA: Remove devm from primary IRQ cleanup")
> Signed-off-by: Lu Yao <yaolu@kylinos.cn>
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> ---

This was already fixed here:
https://lore.kernel.org/linux-sound/20260730130602.3747053-1-ckeepax@opensource.cirrus.com/T/#u

Thanks,
Charles