serial: 8250_dw: Add device HID for AMDI0021 AMD UART controller

[PATCH] serial: 8250_dw: Add device HID for AMDI0021 AMD UART controller

Posted by Steffen Dirkwinkel 1 month, 2 weeks ago

From: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>

This ID is found on AMD V1202B.
Like the AMDI0022 [1] this one works with the same match and the existing driver.
Tested with a loopback cable.

[1] commit 3c35d2a960c0 ("serial: 8250_dw: Add device HID for new AMD UART controller")

Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
---
 drivers/acpi/acpi_apd.c           | 1 +
 drivers/tty/serial/8250/8250_dw.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index 008bd0552cb7..562be86aa272 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -250,6 +250,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
 	{ "AMDI0015", APD_ADDR(wt_i3c_desc) },
 	{ "AMDI0019", APD_ADDR(wt_i2c_desc) },
 	{ "AMDI0020", APD_ADDR(cz_uart_desc) },
+	{ "AMDI0021", APD_ADDR(cz_uart_desc) },
 	{ "AMDI0022", APD_ADDR(cz_uart_desc) },
 	{ "HYGO0010", APD_ADDR(wt_i2c_desc) },
 #endif
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 5fba913f3301..214d3e7ae628 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -910,6 +910,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {
 	{ "8086228A", (kernel_ulong_t)&dw8250_dw_apb },
 	{ "AMD0020", (kernel_ulong_t)&dw8250_dw_apb },
 	{ "AMDI0020", (kernel_ulong_t)&dw8250_dw_apb },
+	{ "AMDI0021", (kernel_ulong_t)&dw8250_dw_apb },
 	{ "AMDI0022", (kernel_ulong_t)&dw8250_dw_apb },
 	{ "APMC0D08", (kernel_ulong_t)&dw8250_apmc0d08 },
 	{ "BRCM2032", (kernel_ulong_t)&dw8250_dw_apb },

---
base-commit: 3aa1dcaa4f6f5ae08936491e08bd456f331f2d40
change-id: 20260813-b4-raven-ridge-uart-62b1ef1fc246

Best regards,
--  
Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>

Re: [PATCH] serial: 8250_dw: Add device HID for AMDI0021 AMD UART controller

Posted by Shyam Sundar S K 1 month, 1 week ago


On 14-08-2026 00:07, Steffen Dirkwinkel wrote:
> From: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
> 
> This ID is found on AMD V1202B.
> Like the AMDI0022 [1] this one works with the same match and the existing driver.
> Tested with a loopback cable.
> 
> [1] commit 3c35d2a960c0 ("serial: 8250_dw: Add device HID for new AMD UART controller")
> 
> Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>

Looked at AMD's ACPI reservation table and this looks right to me.

Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>

> ---
>  drivers/acpi/acpi_apd.c           | 1 +
>  drivers/tty/serial/8250/8250_dw.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index 008bd0552cb7..562be86aa272 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -250,6 +250,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
>  	{ "AMDI0015", APD_ADDR(wt_i3c_desc) },
>  	{ "AMDI0019", APD_ADDR(wt_i2c_desc) },
>  	{ "AMDI0020", APD_ADDR(cz_uart_desc) },
> +	{ "AMDI0021", APD_ADDR(cz_uart_desc) },
>  	{ "AMDI0022", APD_ADDR(cz_uart_desc) },
>  	{ "HYGO0010", APD_ADDR(wt_i2c_desc) },
>  #endif
> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
> index 5fba913f3301..214d3e7ae628 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -910,6 +910,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {
>  	{ "8086228A", (kernel_ulong_t)&dw8250_dw_apb },
>  	{ "AMD0020", (kernel_ulong_t)&dw8250_dw_apb },
>  	{ "AMDI0020", (kernel_ulong_t)&dw8250_dw_apb },
> +	{ "AMDI0021", (kernel_ulong_t)&dw8250_dw_apb },
>  	{ "AMDI0022", (kernel_ulong_t)&dw8250_dw_apb },
>  	{ "APMC0D08", (kernel_ulong_t)&dw8250_apmc0d08 },
>  	{ "BRCM2032", (kernel_ulong_t)&dw8250_dw_apb },
> 
> ---
> base-commit: 3aa1dcaa4f6f5ae08936491e08bd456f331f2d40
> change-id: 20260813-b4-raven-ridge-uart-62b1ef1fc246
> 
> Best regards,
> --  
> Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
>

Re: [PATCH] serial: 8250_dw: Add device HID for AMDI0021 AMD UART controller

Posted by Andy Shevchenko 1 month, 2 weeks ago

On Thu, Aug 13, 2026 at 08:37:05PM +0200, Steffen Dirkwinkel wrote:

> This ID is found on AMD V1202B.
> Like the AMDI0022 [1] this one works with the same match and the existing driver.
> Tested with a loopback cable.

> [1] commit 3c35d2a960c0 ("serial: 8250_dw: Add device HID for new AMD UART controller")

You can also make it a proper Link tag

Link: https://git.kernel.org/torvalds/c/3c35d2a960c0 [1]
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko