[PATCH net-next] net: openvswitch: unexport ovs_vport_alloc/free

Ilya Maximets posted 1 patch 1 month, 2 weeks ago
net/openvswitch/vport.c | 2 --
1 file changed, 2 deletions(-)
[PATCH net-next] net: openvswitch: unexport ovs_vport_alloc/free
Posted by Ilya Maximets 1 month, 2 weeks ago
Since removal of the legacy tunnel port types, there are no more
users for these functions outside the main openvswitch module.
Functions to register vport_ops are also not exported.  Allocating
vports without operations doesn't make a lot of sense.

Highlighted by Sashiko as a follow up to the removal of the module
infrastructure.

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
---
 net/openvswitch/vport.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
index 29ebeb164bdc..083f7a8d9d4e 100644
--- a/net/openvswitch/vport.c
+++ b/net/openvswitch/vport.c
@@ -157,7 +157,6 @@ struct vport *ovs_vport_alloc(int priv_size, const struct vport_ops *ops,
 	kfree(vport);
 	return ERR_PTR(err);
 }
-EXPORT_SYMBOL_GPL(ovs_vport_alloc);
 
 /**
  *	ovs_vport_free - uninitialize and free vport
@@ -178,7 +177,6 @@ void ovs_vport_free(struct vport *vport)
 	free_percpu(vport->upcall_stats);
 	kfree(vport);
 }
-EXPORT_SYMBOL_GPL(ovs_vport_free);
 
 static struct vport_ops *ovs_vport_lookup(const struct vport_parms *parms)
 {
-- 
2.55.0
Re: [PATCH net-next] net: openvswitch: unexport ovs_vport_alloc/free
Posted by Aaron Conole 1 month, 2 weeks ago
Ilya Maximets <i.maximets@ovn.org> writes:

> Since removal of the legacy tunnel port types, there are no more
> users for these functions outside the main openvswitch module.
> Functions to register vport_ops are also not exported.  Allocating
> vports without operations doesn't make a lot of sense.
>
> Highlighted by Sashiko as a follow up to the removal of the module
> infrastructure.
>
> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
> ---
>  net/openvswitch/vport.c | 2 --
>  1 file changed, 2 deletions(-)
>

Reviewed-by: Aaron Conole <aconole@redhat.com>