[v1] staging: sm750fb/sm750.c: mark g_def_fbmode as const pointer

[PATCH] staging: sm750fb/sm750.c: mark g_def_fbmode as const pointer

Posted by Maxim Codita 1 month, 2 weeks ago

Fix a checkpatch.pl warning for g_def_fbmode by marking the pointer
as const. Ensures it is stored as read-only.

Note: g_fbmode[] is left as non-const as its elements are modified at
runtime by lynxfb_set_fbinfo() and sm750fb_setup().

Signed-off-by: Maxim Codita <maxkoditsa7c@gmail.com>
---
 drivers/staging/sm750fb/sm750.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 89c811e0806c..cc38dac88a73 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -22,7 +22,7 @@ static int g_hwcursor = 1;
 static int g_noaccel __ro_after_init;
 static int g_nomtrr __ro_after_init;
 static const char *g_fbmode[] = {NULL, NULL};
-static const char *g_def_fbmode = "1024x768-32@60";
+static const char  * const g_def_fbmode = "1024x768-32@60";
 static char *g_settings;
 static int g_dualview __ro_after_init;
 static char *g_option;
-- 
2.53.0

Re: [PATCH] staging: sm750fb/sm750.c: mark g_def_fbmode as const pointer

Posted by Greg Kroah-Hartman 1 month, 2 weeks ago

On Tue, Aug 11, 2026 at 03:08:13PM +0200, Maxim Codita wrote:
> Fix a checkpatch.pl warning for g_def_fbmode by marking the pointer
> as const. Ensures it is stored as read-only.
> 
> Note: g_fbmode[] is left as non-const as its elements are modified at
> runtime by lynxfb_set_fbinfo() and sm750fb_setup().
> 
> Signed-off-by: Maxim Codita <maxkoditsa7c@gmail.com>
> ---
>  drivers/staging/sm750fb/sm750.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 89c811e0806c..cc38dac88a73 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -22,7 +22,7 @@ static int g_hwcursor = 1;
>  static int g_noaccel __ro_after_init;
>  static int g_nomtrr __ro_after_init;
>  static const char *g_fbmode[] = {NULL, NULL};
> -static const char *g_def_fbmode = "1024x768-32@60";
> +static const char  * const g_def_fbmode = "1024x768-32@60";

The spacing here looks very odd, don't you think?

And how was this tested?

thanks,

greg k-h

[PATCH v2] staging: sm750fb/sm750.c: mark g_def_fbmode as const pointer

Posted by Maxim Codita 1 month, 2 weeks ago

Fix a checkpatch.pl warning for g_def_fbmode by marking the pointer
as const. Ensures it is stored as read-only.

Note: g_fbmode[] is left as non-const as its elements are modified at
runtime by lynxfb_set_fbinfo() and sm750fb_setup().

Signed-off-by: Maxim Codita <maxkoditsa7c@gmail.com>
---
v2:
Fixed extra spacing between char and *
Compile tested with make drivers/staging/sm750fb/ (no hardware to check
runtime)
---
 drivers/staging/sm750fb/sm750.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 89c811e0806c..b2f5f49e447a 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -22,7 +22,7 @@ static int g_hwcursor = 1;
 static int g_noaccel __ro_after_init;
 static int g_nomtrr __ro_after_init;
 static const char *g_fbmode[] = {NULL, NULL};
-static const char *g_def_fbmode = "1024x768-32@60";
+static const char * const g_def_fbmode = "1024x768-32@60";
 static char *g_settings;
 static int g_dualview __ro_after_init;
 static char *g_option;
-- 
2.53.0