Hello,
this is the v3 of the series aiming to reduce the flakyness of
tc_tunnel/tc_edt tests in CI. This revision handles Ihor's feedback
about the need to conform to the timeout value passed in opts->timeout.
The first commit has been reorganized a bit more than what was needed
for this change, to make sure that the code can be followed easily.
There's also now a second commit to make sure that test_tc_edt benefits
from this new connect() handling.
Signed-off-by: Alexis Lothoré (eBPF Foundation) <alexis.lothore@bootlin.com>
---
Changes in v3:
- set errno before logging errors
- respect time budget set by
- respect opts->timeout_ms when polling: only poll for the remaining
time not already consume by connect()
- keep polling if poll returns with EINTR
- reorder early returns and add intermediate variables to clarify code
flow
- Link to v2: https://patch.msgid.link/20260803-tc_tunnel_flaky-v2-1-657b287dfa75@bootlin.com
Changes in v2:
- drop unneeded initialization
- add back error message for immediate connection failure, and slightly
reword the async connection failure error message
- Link to v1: https://patch.msgid.link/20260710-tc_tunnel_flaky-v1-1-42aab5399a49@bootlin.com
To: Alexei Starovoitov <ast@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
To: Andrii Nakryiko <andrii@kernel.org>
To: Eduard Zingerman <eddyz87@gmail.com>
To: Kumar Kartikeya Dwivedi <memxor@gmail.com>
To: Martin KaFai Lau <martin.lau@linux.dev>
To: Song Liu <song@kernel.org>
To: Yonghong Song <yonghong.song@linux.dev>
To: Jiri Olsa <jolsa@kernel.org>
To: Emil Tsalapatis <emil@etsalapatis.com>
To: Ihor Solodrai <ihor.solodrai@linux.dev>
To: Shuah Khan <shuah@kernel.org>
Cc: ebpf@linuxfoundation.org
Cc: Bastien Curutchet <bastien.curutchet@bootlin.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: bpf@vger.kernel.org
Cc: linux-kselftest@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
Alexis Lothoré (eBPF Foundation) (2):
selftests/bpf: keep polling connection that is still in progress
selftests/bpf: add connect timeout to test_tc_edt
tools/testing/selftests/bpf/network_helpers.c | 70 ++++++++++++++++++++--
.../testing/selftests/bpf/prog_tests/test_tc_edt.c | 2 +-
tools/testing/selftests/bpf/testing_helpers.h | 9 +++
3 files changed, 75 insertions(+), 6 deletions(-)
---
base-commit: 53cc65185a51fa9dd288cd1137a21467eced2df4
change-id: 20260710-tc_tunnel_flaky-27e9a191bd03
Best regards,
--
Alexis Lothoré (eBPF Foundation) <alexis.lothore@bootlin.com>