[PATCH net v3 0/2] net: thunderbolt: two fixes for the failed bring-up path

Fan Ye via B4 Relay posted 2 patches 1 month, 2 weeks ago
drivers/net/thunderbolt/main.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
[PATCH net v3 0/2] net: thunderbolt: two fixes for the failed bring-up path
Posted by Fan Ye via B4 Relay 1 month, 2 weeks ago
Two separate defects reached through the same branch in
tbnet_connected_work(), found on an ASMedia ASM4242 host-to-host link
when the peer drops out while a connection is being brought up.

  1 releases the HopID the allocator handed out when it is not the one
    that was asked for.  Today it stays allocated for the rest of the
    XDomain connection.

  2 marks the connection down on the failure paths, so the next
    tbnet_tear_down() does not run a second teardown over work that was
    already undone: stopping rings that are already stopped, which is
    fatal under panic_on_warn, and handing back a HopID this connection
    never owned.

Patch 2 edits the lines patch 1 adds, so it has to come second.

Changes in v3:
- Cut both commit messages down after review; the code is unchanged
  apart from the comment on the new helper in patch 2, now one line.
- Link to v2: https://lore.kernel.org/netdev/20260810-b4-tbnet-hopid-v2-0-0eee557e75df@gmail.com/

---
Fan Ye (2):
      net: thunderbolt: Release the Rx HopID that was handed out on mismatch
      net: thunderbolt: Mark the connection down when bringing it up fails

 drivers/net/thunderbolt/main.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
---
base-commit: d58772d8520c7ef247c4b95c9bd76d3a25da9ff5
change-id: 20260811-b4-tbnet-hopid-d542741b363d

Best regards,
--  
Fan Ye <fy15309206903@gmail.com>
Re: [PATCH net v3 0/2] net: thunderbolt: two fixes for the failed bring-up path
Posted by Simon Horman 1 month, 2 weeks ago
On Tue, Aug 11, 2026 at 01:20:48PM +0000, Fan Ye via B4 Relay wrote:
> Two separate defects reached through the same branch in
> tbnet_connected_work(), found on an ASMedia ASM4242 host-to-host link
> when the peer drops out while a connection is being brought up.
> 
>   1 releases the HopID the allocator handed out when it is not the one
>     that was asked for.  Today it stays allocated for the rest of the
>     XDomain connection.
> 
>   2 marks the connection down on the failure paths, so the next
>     tbnet_tear_down() does not run a second teardown over work that was
>     already undone: stopping rings that are already stopped, which is
>     fatal under panic_on_warn, and handing back a HopID this connection
>     never owned.
> 
> Patch 2 edits the lines patch 1 adds, so it has to come second.
> 
> Changes in v3:
> - Cut both commit messages down after review; the code is unchanged
>   apart from the comment on the new helper in patch 2, now one line.
> - Link to v2: https://lore.kernel.org/netdev/20260810-b4-tbnet-hopid-v2-0-0eee557e75df@gmail.com/

For the series:

Reviewed-by: Simon Horman <horms@kernel.org>