[PATCH] rust: kernel: list: fix incorrect pop_back example comment

Nikolai Grlica posted 1 patch 1 month, 2 weeks ago
rust/kernel/list.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] rust: kernel: list: fix incorrect pop_back example comment
Posted by Nikolai Grlica 1 month, 2 weeks ago
The example uses pop_back(), but the accompanying comment says
pop_front(). Update the comment to match the example.

Signed-off-by: Nikolai Grlica <nikolai@nikolaigrlica.dev>
---
 rust/kernel/list.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/list.rs b/rust/kernel/list.rs
index 406e3a028c55..0f367264ee2e 100644
--- a/rust/kernel/list.rs
+++ b/rust/kernel/list.rs
@@ -249,7 +249,7 @@
 ///     assert_eq!(list.iter().count(), 3);
 /// }
 ///
-/// // Pop the items from the list using `pop_front()` and verify the content.
+/// // Pop the items from the list using `pop_back()` and verify the content.
 /// {
 ///     assert_eq!(list.pop_back().ok_or(EINVAL)?.value.foo(), ("a", 15));
 ///     assert_eq!(list.pop_back().ok_or(EINVAL)?.value.foo(), ("a", 32));
-- 
2.55.0
Re: [PATCH] rust: kernel: list: fix incorrect pop_back example comment
Posted by Miguel Ojeda 1 month ago
On Mon, Aug 10, 2026 at 5:03 PM Nikolai Grlica
<nikolai@nikolaigrlica.dev> wrote:
>
> The example uses pop_back(), but the accompanying comment says
> pop_front(). Update the comment to match the example.
>
> Signed-off-by: Nikolai Grlica <nikolai@nikolaigrlica.dev>

Applied to `rust-fixes` -- thanks!

    Cc: stable@vger.kernel.org
    Fixes: bf87a41b85d6 ("rust: list: Add an example for
`ListLinksSelfPtr` usage")

Cheers,
Miguel
Re: [PATCH] rust: kernel: list: fix incorrect pop_back example comment
Posted by Miguel Ojeda 1 month, 2 weeks ago
On Mon, Aug 10, 2026 at 5:03 PM Nikolai Grlica
<nikolai@nikolaigrlica.dev> wrote:
>
> The example uses pop_back(), but the accompanying comment says
> pop_front(). Update the comment to match the example.
>
> Signed-off-by: Nikolai Grlica <nikolai@nikolaigrlica.dev>

Good eyes, thanks -- and welcome! I think it is your first patch to
the kernel (?).

Some extra tags I will add when applying it:

Cc: stable@vger.kernel.org
Fixes: bf87a41b85d6 ("rust: list: Add an example for `ListLinksSelfPtr` usage")

By the way, for future patches, please remember to Cc the relevant
reviewers and maintainers -- you can use e.g.
`scripts/get_maintainer.pl` for that. Done here for you! :) I have
some other tips and links here:

  https://rust-for-linux.com/contributing

I hope that helps!

Cheers,
Miguel