MXC and MMCX were initially omitted as they were believed to have no
consumers, and they were not present downstream either.

The Iris video codec requires these power domains, so add MXC and MMCX
along with the MXC_AO and MMCX_AO.

Fixes: f387ecdd492f ("pmdomain: qcom: rpmhpd: Add Eliza RPMh Power Domains")
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
 drivers/pmdomain/qcom/rpmhpd.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/pmdomain/qcom/rpmhpd.c b/drivers/pmdomain/qcom/rpmhpd.c
index 90743275942d..96e4bd2f5a14 100644
--- a/drivers/pmdomain/qcom/rpmhpd.c
+++ b/drivers/pmdomain/qcom/rpmhpd.c
@@ -241,9 +241,13 @@ static struct rpmhpd *eliza_rpmhpds[] = {
 	[RPMHPD_GFX] = &gfx,
 	[RPMHPD_LCX] = &lcx,
 	[RPMHPD_LMX] = &lmx,
+	[RPMHPD_MMCX] = &mmcx,
+	[RPMHPD_MMCX_AO] = &mmcx_ao,
 	[RPMHPD_MSS] = &mss,
 	[RPMHPD_MX] = &mx,
 	[RPMHPD_MX_AO] = &mx_ao,
+	[RPMHPD_MXC] = &mxc,
+	[RPMHPD_MXC_AO] = &mxc_ao,
 	[RPMHPD_NSP] = &nsp,
 };
 

---
base-commit: 6b8c8af514d739d0335f5579b585e02babe8a727
change-id: 20260810-pmdomain-add-missing-mxc-mmcx-on-eliza-6fcb519048e5

Best regards,
--  
Abel Vesa <abel.vesa@oss.qualcomm.com>

On Mon, Aug 10, 2026 at 02:10:38PM +0300, Abel Vesa wrote:
> MXC and MMCX were initially omitted as they were believed to have no
> consumers, and they were not present downstream either.
> 
> The Iris video codec requires these power domains, so add MXC and MMCX
> along with the MXC_AO and MMCX_AO.

Is the display completely sitting in the MX domain?

> 
> Fixes: f387ecdd492f ("pmdomain: qcom: rpmhpd: Add Eliza RPMh Power Domains")
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
>  drivers/pmdomain/qcom/rpmhpd.c | 4 ++++
>  1 file changed, 4 insertions(+)

-- 
With best wishes
Dmitry

On 26-08-11 17:09:00, Dmitry Baryshkov wrote:
> On Mon, Aug 10, 2026 at 02:10:38PM +0300, Abel Vesa wrote:
> > MXC and MMCX were initially omitted as they were believed to have no
> > consumers, and they were not present downstream either.
> > 
> > The Iris video codec requires these power domains, so add MXC and MMCX
> > along with the MXC_AO and MMCX_AO.
> 
> Is the display completely sitting in the MX domain?

Sorry for the late reply.

Yes, it seems display is in MX only.

On Mon, Aug 10, 2026 at 1:10 PM Abel Vesa <abel.vesa@oss.qualcomm.com> wrote:
>
> MXC and MMCX were initially omitted as they were believed to have no
> consumers, and they were not present downstream either.
>
> The Iris video codec requires these power domains, so add MXC and MMCX
> along with the MXC_AO and MMCX_AO.
>
> Fixes: f387ecdd492f ("pmdomain: qcom: rpmhpd: Add Eliza RPMh Power Domains")
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

Applied for fixes and by adding a stable tag, thanks!

Kind regards
Uffe

> ---
>  drivers/pmdomain/qcom/rpmhpd.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pmdomain/qcom/rpmhpd.c b/drivers/pmdomain/qcom/rpmhpd.c
> index 90743275942d..96e4bd2f5a14 100644
> --- a/drivers/pmdomain/qcom/rpmhpd.c
> +++ b/drivers/pmdomain/qcom/rpmhpd.c
> @@ -241,9 +241,13 @@ static struct rpmhpd *eliza_rpmhpds[] = {
>         [RPMHPD_GFX] = &gfx,
>         [RPMHPD_LCX] = &lcx,
>         [RPMHPD_LMX] = &lmx,
> +       [RPMHPD_MMCX] = &mmcx,
> +       [RPMHPD_MMCX_AO] = &mmcx_ao,
>         [RPMHPD_MSS] = &mss,
>         [RPMHPD_MX] = &mx,
>         [RPMHPD_MX_AO] = &mx_ao,
> +       [RPMHPD_MXC] = &mxc,
> +       [RPMHPD_MXC_AO] = &mxc_ao,
>         [RPMHPD_NSP] = &nsp,
>  };
>
>
> ---
> base-commit: 6b8c8af514d739d0335f5579b585e02babe8a727
> change-id: 20260810-pmdomain-add-missing-mxc-mmcx-on-eliza-6fcb519048e5
>
> Best regards,
> --
> Abel Vesa <abel.vesa@oss.qualcomm.com>
>

On 26-08-11 12:30:42, Ulf Hansson wrote:
> On Mon, Aug 10, 2026 at 1:10 PM Abel Vesa <abel.vesa@oss.qualcomm.com> wrote:
> >
> > MXC and MMCX were initially omitted as they were believed to have no
> > consumers, and they were not present downstream either.
> >
> > The Iris video codec requires these power domains, so add MXC and MMCX
> > along with the MXC_AO and MMCX_AO.
> >
> > Fixes: f387ecdd492f ("pmdomain: qcom: rpmhpd: Add Eliza RPMh Power Domains")
> > Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> 
> Applied for fixes and by adding a stable tag, thanks!

So I think this one needs to be reverted after all.

The MXC and MMCX are indeed available in the cmd-db, which has been the
main source of information for this until recently. Also, Iris video
codec bring-up engineer thought they were necessary. Meanwhile, after
discussing off-list, it has been concluded that these are indeed not
wired up in HW, therefore, even if they show up in cmd-db, they are not
actually there. So I'll send a revert for this soon.

Sorry about the whole mess.

On Tue, Aug 18, 2026 at 12:00 PM Abel Vesa <abel.vesa@oss.qualcomm.com> wrote:
>
> On 26-08-11 12:30:42, Ulf Hansson wrote:
> > On Mon, Aug 10, 2026 at 1:10 PM Abel Vesa <abel.vesa@oss.qualcomm.com> wrote:
> > >
> > > MXC and MMCX were initially omitted as they were believed to have no
> > > consumers, and they were not present downstream either.
> > >
> > > The Iris video codec requires these power domains, so add MXC and MMCX
> > > along with the MXC_AO and MMCX_AO.
> > >
> > > Fixes: f387ecdd492f ("pmdomain: qcom: rpmhpd: Add Eliza RPMh Power Domains")
> > > Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> >
> > Applied for fixes and by adding a stable tag, thanks!
>
> So I think this one needs to be reverted after all.
>
> The MXC and MMCX are indeed available in the cmd-db, which has been the
> main source of information for this until recently. Also, Iris video
> codec bring-up engineer thought they were necessary. Meanwhile, after
> discussing off-list, it has been concluded that these are indeed not
> wired up in HW, therefore, even if they show up in cmd-db, they are not
> actually there. So I'll send a revert for this soon.
>
> Sorry about the whole mess.

No worries, please send a fix that we can queue as a fix and for
stable then, thanks!

Kind regards
Uffe