This series adds two validations to the target configuration when the
user tries to enable it: first whether remote_ip was set, and second
whether local_ip and remote_ip address families match. Refuse to enable
the target if any of those validations fail.
These validations are already done for the target passed on the
command-line, so this aligns dynamic targets with the command-line
behavior.
The first two patches replace the per-target 'ipv6' flag with a
per-address 'family' field, which makes it easier to detect these error
conditions. Patches 3 and 4 implement the actual validations.
Patches 5 and 6 are follow-ups from review of v1: move inet_addr from
netpoll.h into netconsole.c, and show an unset address as an empty
string rather than "0.0.0.0".
Signed-off-by: Gustavo Luiz Duarte <gustavold@gmail.com>
---
Changes in v2:
- Show empty string in configfs for an unset IP address
- Moved inet_addr definition from netpoll.h to netconsole.c
- Moved address checks out of rtnl_lock()
- Link to v1: https://patch.msgid.link/20260805-netcons_ipv6-v1-0-170a35b92da1@gmail.com
To: Breno Leitao <leitao@debian.org>
To: Andrew Lunn <andrew+netdev@lunn.ch>
To: "David S. Miller" <davem@davemloft.net>
To: Eric Dumazet <edumazet@google.com>
To: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
To: Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
Gustavo Luiz Duarte (6):
netconsole: add an address family to struct inet_addr
netconsole: use the address family instead of the ipv6 flag
netconsole: reject enabling a target with no remote IP address
netconsole: reject a target mixing IPv4 and IPv6 addresses
netconsole: show empty string for an unset IP address
netconsole: move struct inet_addr into netconsole.c
drivers/net/netconsole.c | 132 +++++++++++++++++++++++------------------------
include/linux/netpoll.h | 5 --
2 files changed, 65 insertions(+), 72 deletions(-)
---
base-commit: a23b36233d4103def55dc8cf65698106d0bd1e62
change-id: 20260730-netcons_ipv6-565d55f55729
Best regards,
--
Gustavo Luiz Duarte <gustavold@gmail.com>