staging: rtl8723bs: rtw_ap: fix line wrapping and logical continuation checks

[PATCH] staging: rtl8723bs: rtw_ap: fix line wrapping and logical continuation checks

Posted by Andria Shengelia 1 month, 2 weeks ago

Reformat multi-line conditional expression wrapping in rtw_ap.c to fix
checkpatch.pl checks regarding logical continuations being placed at the
beginning of lines and lines ending with opening parentheses.

Signed-off-by: Andria Shengelia <shengeliaandria9@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index a6dc88dd4..9c14ba1dc 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -258,11 +258,9 @@ void expire_timeout_chk(struct adapter *padapter)
 		} else {
 			/* TODO: Aging mechanism to digest frames in sleep_q to */
 			/* avoid running out of xmitframe */
-			if (psta->sleepq_len > (NR_XMITFRAME / pstapriv->asoc_list_cnt)
-				&& padapter->xmitpriv.free_xmitframe_cnt < ((
-					NR_XMITFRAME / pstapriv->asoc_list_cnt
-				) / 2)
-			)
+			if (psta->sleepq_len > (NR_XMITFRAME / pstapriv->asoc_list_cnt) &&
+			    padapter->xmitpriv.free_xmitframe_cnt <
+			    (NR_XMITFRAME / pstapriv->asoc_list_cnt) / 2)
 				wakeup_sta_to_xmit(padapter, psta);
 		}
 	}
-- 
2.55.0

Re: [PATCH] staging: rtl8723bs: rtw_ap: fix line wrapping and logical continuation checks

Posted by Greg Kroah-Hartman 3 weeks, 6 days ago

On Sun, Aug 09, 2026 at 06:43:55PM +0400, Andria Shengelia wrote:
> Reformat multi-line conditional expression wrapping in rtw_ap.c to fix
> checkpatch.pl checks regarding logical continuations being placed at the
> beginning of lines and lines ending with opening parentheses.
> 
> Signed-off-by: Andria Shengelia <shengeliaandria9@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ap.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index a6dc88dd4..9c14ba1dc 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -258,11 +258,9 @@ void expire_timeout_chk(struct adapter *padapter)
>  		} else {
>  			/* TODO: Aging mechanism to digest frames in sleep_q to */
>  			/* avoid running out of xmitframe */
> -			if (psta->sleepq_len > (NR_XMITFRAME / pstapriv->asoc_list_cnt)
> -				&& padapter->xmitpriv.free_xmitframe_cnt < ((
> -					NR_XMITFRAME / pstapriv->asoc_list_cnt
> -				) / 2)
> -			)
> +			if (psta->sleepq_len > (NR_XMITFRAME / pstapriv->asoc_list_cnt) &&
> +			    padapter->xmitpriv.free_xmitframe_cnt <
> +			    (NR_XMITFRAME / pstapriv->asoc_list_cnt) / 2)
>  				wakeup_sta_to_xmit(padapter, psta);
>  		}
>  	}
> -- 
> 2.55.0
> 
> 

Does not apply to the current staging-testing branch :(

Please rebase and resend.

thanks,

greg k-h