staging: greybus: gbphy: use sysfs_emit() instead of sprintf()

[PATCH] staging: greybus: gbphy: use sysfs_emit() instead of sprintf()

Posted by Mohit Mishra 1 month, 3 weeks ago

protocol_id_show() uses sprintf() to format sysfs output into the page
buffer. Convert it to sysfs_emit(), which is the preferred helper for
sysfs show() callbacks as it enforces page boundary checks.

Similar conversions have already been made elsewhere in this subsystem
(e.g. loopback.c, arche-platform.c).

Signed-off-by: Mohit Mishra <mishraloopmohit@gmail.com>
---
 drivers/staging/greybus/gbphy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
index bdb0f5164a6f..bb9a5b538e6e 100644
--- a/drivers/staging/greybus/gbphy.c
+++ b/drivers/staging/greybus/gbphy.c
@@ -31,7 +31,7 @@ static ssize_t protocol_id_show(struct device *dev,
 {
 	struct gbphy_device *gbphy_dev = to_gbphy_dev(dev);
 
-	return sprintf(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id);
+	return sysfs_emit(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id);
 }
 static DEVICE_ATTR_RO(protocol_id);
 
-- 
2.43.0

Re: [PATCH] staging: greybus: gbphy: use sysfs_emit() instead of sprintf()

Posted by Greg Kroah-Hartman 4 weeks ago

On Sat, Aug 08, 2026 at 10:43:02PM +0530, Mohit Mishra wrote:
> protocol_id_show() uses sprintf() to format sysfs output into the page
> buffer. Convert it to sysfs_emit(), which is the preferred helper for
> sysfs show() callbacks as it enforces page boundary checks.
> 
> Similar conversions have already been made elsewhere in this subsystem
> (e.g. loopback.c, arche-platform.c).
> 
> Signed-off-by: Mohit Mishra <mishraloopmohit@gmail.com>
> ---
>  drivers/staging/greybus/gbphy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
> index bdb0f5164a6f..bb9a5b538e6e 100644
> --- a/drivers/staging/greybus/gbphy.c
> +++ b/drivers/staging/greybus/gbphy.c
> @@ -31,7 +31,7 @@ static ssize_t protocol_id_show(struct device *dev,
>  {
>  	struct gbphy_device *gbphy_dev = to_gbphy_dev(dev);
>  
> -	return sprintf(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id);
> +	return sysfs_emit(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id);
>  }
>  static DEVICE_ATTR_RO(protocol_id);
>  
> -- 
> 2.43.0
> 

Please see the mailing list archives for why this type of patch keeps
getting rejected.

sorry,

greg k-h