[PATCH v7 0/2] usb: typec: ucsi: Add ITE IT8851/IT8853 support

Amber Kao posted 2 patches 1 month, 3 weeks ago
.../devicetree/bindings/usb/ite,it8851.yaml        | 156 +++++++++
MAINTAINERS                                        |   9 +
drivers/usb/typec/ucsi/Kconfig                     |  10 +
drivers/usb/typec/ucsi/Makefile                    |   1 +
drivers/usb/typec/ucsi/ucsi_itepd.c                | 356 +++++++++++++++++++++
5 files changed, 532 insertions(+)
[PATCH v7 0/2] usb: typec: ucsi: Add ITE IT8851/IT8853 support
Posted by Amber Kao 1 month, 3 weeks ago
This series adds Device Tree bindings and minimal UCSI driver support 
for the ITE IT8851/IT8853 USB Type-C Power Delivery controller over I2C.

Changes in v7:
- dt-bindings: define 'reg' for the connector@[01] nodes, since a
  unit-address requires a 'reg' property.
- dt-bindings: dropped Krzysztof's Reviewed-by tag due to the above
  change.
- ucsi_itepd: use guard(mutex) in itepd_process_event(),
  ucsi_itepd_read_cci() and ucsi_itepd_read_message_in().
- ucsi_itepd: kept request_threaded_irq() instead of
  devm_request_threaded_irq(). ucsi_destroy() is not devres-managed and
  runs inside remove(), while a devm IRQ is only released after remove()
  has returned; an interrupt in that window would call
  ucsi_notify_common() on an already destroyed ucsi instance.

Link to v6: https://patch.msgid.link/20260731-ucsi-itepd-v6-0-d25ae12b181f@ite.com.tw
Link to v5: https://patch.msgid.link/20260724-ucsi-itepd-v5-0-d1a83e5c9c77@ite.com.tw
Link to v4: https://lore.kernel.org/all/20260717-ucsi-itepd-v4-0-f3ba5addd0df@ite.com.tw/
Link to v3: https://lore.kernel.org/all/20260710-ucsi-itepd-feature-v3-0-8523e1e1c47a@ite.com.tw/
Link to v2: https://lore.kernel.org/all/20260710-ucsi-itepd-feature-v2-0-41943fd5df38@ite.com.tw/
Link to v1: https://lore.kernel.org/all/20260615-ucsi-itepd-feature-v1-0-a826cfd0df6a@ite.com.tw/

Signed-off-by: Amber Kao <amber.kao@ite.com.tw>
---
Amber Kao (2):
      dt-bindings: usb: Add ITE IT8851/IT8853 Type-C PD controllers
      usb: typec: ucsi: Add ITE IT8851/IT8853 Type-C PD controller driver

 .../devicetree/bindings/usb/ite,it8851.yaml        | 156 +++++++++
 MAINTAINERS                                        |   9 +
 drivers/usb/typec/ucsi/Kconfig                     |  10 +
 drivers/usb/typec/ucsi/Makefile                    |   1 +
 drivers/usb/typec/ucsi/ucsi_itepd.c                | 356 +++++++++++++++++++++
 5 files changed, 532 insertions(+)
---
base-commit: 8fde5d1d47f69db6082dfa34500c27f8485389a5
change-id: 20260717-ucsi-itepd-4e943e1382f0

Best regards,
--  
Amber Kao <amber.kao@ite.com.tw>
Re: [PATCH v7 0/2] usb: typec: ucsi: Add ITE IT8851/IT8853 support
Posted by Heikki Krogerus 1 month, 2 weeks ago
On Fri, Aug 07, 2026 at 06:17:44PM +0800, Amber Kao wrote:
> This series adds Device Tree bindings and minimal UCSI driver support 
> for the ITE IT8851/IT8853 USB Type-C Power Delivery controller over I2C.
> 
> Changes in v7:
> - dt-bindings: define 'reg' for the connector@[01] nodes, since a
>   unit-address requires a 'reg' property.
> - dt-bindings: dropped Krzysztof's Reviewed-by tag due to the above
>   change.
> - ucsi_itepd: use guard(mutex) in itepd_process_event(),
>   ucsi_itepd_read_cci() and ucsi_itepd_read_message_in().
> - ucsi_itepd: kept request_threaded_irq() instead of
>   devm_request_threaded_irq(). ucsi_destroy() is not devres-managed and
>   runs inside remove(), while a devm IRQ is only released after remove()
>   has returned; an interrupt in that window would call
>   ucsi_notify_common() on an already destroyed ucsi instance.

Why are you answering questions here in the changelog instead of the
thread where they were originally asked?

Changelog should really only list the things that were change.

Thanks,

-- 
heikki