[PATCH] mm/damon/core: remove declaration of __damon_commit_ctx()

Zenghui Yu posted 1 patch 1 month, 3 weeks ago
mm/damon/core.c | 2 --
1 file changed, 2 deletions(-)
[PATCH] mm/damon/core: remove declaration of __damon_commit_ctx()
Posted by Zenghui Yu 1 month, 3 weeks ago
From: "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>

It was added by commit b1471afe4d10 ("mm/damon/core: do parameter testing
commit on damon_start()") but is actually not needed.  Remove it.

Signed-off-by: Zenghui Yu (Huawei) <zenghui.yu@linux.dev>
---
 mm/damon/core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index e03df0a61060..fb884b2b1c92 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -1954,8 +1954,6 @@ static int __damon_start(struct damon_ctx *ctx)
 	return err;
 }
 
-static int __damon_commit_ctx(struct damon_ctx *dst, struct damon_ctx *src);
-
 /**
  * damon_start() - Starts the monitorings for a given group of contexts.
  * @ctxs:	an array of the pointers for contexts to start monitoring
-- 
2.53.0
Re: [PATCH] mm/damon/core: remove declaration of __damon_commit_ctx()
Posted by SJ Park 1 month, 3 weeks ago
On Fri,  7 Aug 2026 01:07:01 +0800 Zenghui Yu <zenghui.yu@linux.dev> wrote:

> From: "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>
> 
> It was added by commit b1471afe4d10 ("mm/damon/core: do parameter testing
> commit on damon_start()") but is actually not needed.  Remove it.

Thank you for finding and fixing this, Zenghui!

> 
> Signed-off-by: Zenghui Yu (Huawei) <zenghui.yu@linux.dev>

Reviewed-by: SJ Park <sj@kernel.org>

I applied  this patch to damon/next [1] tree.  We are now quite close to next
merge window.  We (mm community) want to focus on making mm.git more stabilized
and therefore ready for the next merge window, rather than adding more changes
that are not really urgent.  I understand this series is not really urgent.
Hence, Andrew might not add this patch until next -rc1 release.  In the case, I
will request adding this to mm.git after next -rc1 release.  So, no action from
your side is needed for now.  Let me know if you think this is really  urgent.

[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees


Thanks,
SJ

[...]