Hi EDAC maintainers,

I wanted to explain the reason why I think this patch doesn't need a
Fixes tag. The way the Altera EDAC is written there are many instances
of the driver referencing the of_node, which is why they are flagged in
many sashiko reviews.

This patch checks for those NULL of_node in the probe functions using
dev_of_node() so we don't have to guard the of_node in all the other
functions.

The reason we don't need the Fixes tag is because this system is
supposed to run with CONFIG_OF enabled. The system would fail way
before it gets to this driver if an of_node is not found. Thus I don't
see a need for a Fixes tag but the guard should be in place for
completeness.

Thanks,

Dinh Nguyen (1):
  EDAC/altera: Guard against NULL of_node pointer dereference

 drivers/edac/altera_edac.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

-- 
2.42.0.411.g813d9a9188

On Thu, Aug 06, 2026 at 11:10:54AM -0500, Dinh Nguyen wrote:
> Hi EDAC maintainers,
> 
> I wanted to explain the reason why I think this patch doesn't need a
> Fixes tag. The way the Altera EDAC is written there are many instances
> of the driver referencing the of_node, which is why they are flagged in
> many sashiko reviews.

If you think this patch would make your life easier, then sure. But
we're not "fixing" the code just because a tool is stupid. No matter which
tool it is.

Thx.