Reword the SDCA HID code

[PATCH 0/8] Reword the SDCA HID code

Posted by Charles Keepax 1 month, 3 weeks ago

This series reworks the SDCA HID code, the primary goals being to no
longer store runtime HID data in the DisCo data structures and remove
the need to pass the soundwire device into the ACPI parsing code.

To achieve this the HID device registration is moved to the IRQ work
flow rather than the ACPI work flow.

Also a few small issues are fixed up along the way, some formatting,
some missing cleanup/docs.

Thanks,
Charles

Charles Keepax (8):
  ASoC: SDCA: Tidy up error message
  ASoC: SDCA: Remove unused dev pointer argument
  ASoC: SDCA: Move HID registration to IRQ time
  ASoC: SDCA: Move HID descriptors to function
  ASoC: SDCA: Update HID DisCo parsing
  ASoC: SDCA: Add missing destroy for HID device
  ASoC: SDCA: Add missing HID kernel doc
  ASoC: SDCA: Pass swft table through sdca_dev_register()

 include/sound/sdca_asoc.h             |   8 +-
 include/sound/sdca_function.h         |  24 ++--
 include/sound/sdca_hid.h              |  11 +-
 sound/soc/codecs/rt766-sdca.c         |  26 +++-
 sound/soc/codecs/rt766-sdca.h         |   2 +
 sound/soc/codecs/tac5xx2-sdw.c        |   6 +-
 sound/soc/codecs/tas2783-sdw.c        |   2 +-
 sound/soc/sdca/sdca_asoc.c            |  13 +-
 sound/soc/sdca/sdca_class_function.c  |   2 +-
 sound/soc/sdca/sdca_function_device.c |   7 +-
 sound/soc/sdca/sdca_functions.c       | 180 +++++++++++++++-----------
 sound/soc/sdca/sdca_hid.c             |  48 ++++---
 sound/soc/sdca/sdca_interrupts.c      |   6 +
 13 files changed, 211 insertions(+), 124 deletions(-)

-- 
2.47.3

Re: [PATCH 0/8] Reword the SDCA HID code

Posted by Pierre-Louis Bossart 1 month, 3 weeks ago

On 8/5/26 14:41, Charles Keepax wrote:
> This series reworks the SDCA HID code, the primary goals being to no
> longer store runtime HID data in the DisCo data structures and remove
> the need to pass the soundwire device into the ACPI parsing code.
> 
> To achieve this the HID device registration is moved to the IRQ work
> flow rather than the ACPI work flow.
> 
> Also a few small issues are fixed up along the way, some formatting,
> some missing cleanup/docs.
> 
> Thanks,
> Charles
> 
> Charles Keepax (8):
>   ASoC: SDCA: Tidy up error message
>   ASoC: SDCA: Remove unused dev pointer argument
>   ASoC: SDCA: Move HID registration to IRQ time
>   ASoC: SDCA: Move HID descriptors to function
>   ASoC: SDCA: Update HID DisCo parsing
>   ASoC: SDCA: Add missing destroy for HID device
>   ASoC: SDCA: Add missing HID kernel doc
>   ASoC: SDCA: Pass swft table through sdca_dev_register()


LGTM

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>

Re: [PATCH 0/8] Reword the SDCA HID code

Posted by Mark Brown 1 month, 3 weeks ago

On Wed, 05 Aug 2026 13:41:57 +0100, Charles Keepax wrote:
> Reword the SDCA HID code
> 
> This series reworks the SDCA HID code, the primary goals being to no
> longer store runtime HID data in the DisCo data structures and remove
> the need to pass the soundwire device into the ACPI parsing code.
> 
> To achieve this the HID device registration is moved to the IRQ work
> flow rather than the ACPI work flow.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3

Thanks!

[1/8] ASoC: SDCA: Tidy up error message
      https://git.kernel.org/broonie/sound/c/6a236928b43c
[2/8] ASoC: SDCA: Remove unused dev pointer argument
      https://git.kernel.org/broonie/sound/c/3dcc74d51b22
[3/8] ASoC: SDCA: Move HID registration to IRQ time
      https://git.kernel.org/broonie/sound/c/c03f0b9a7d99
[4/8] ASoC: SDCA: Move HID descriptors to function
      https://git.kernel.org/broonie/sound/c/f3243b79026e
[5/8] ASoC: SDCA: Update HID DisCo parsing
      https://git.kernel.org/broonie/sound/c/01dba3e93486
[6/8] ASoC: SDCA: Add missing destroy for HID device
      https://git.kernel.org/broonie/sound/c/df1fd5d8ab40
[7/8] ASoC: SDCA: Add missing HID kernel doc
      https://git.kernel.org/broonie/sound/c/3ede9e98ca1c
[8/8] ASoC: SDCA: Pass swft table through sdca_dev_register()
      https://git.kernel.org/broonie/sound/c/a50e530e05fa

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark