[PATCH] dt-bindings: gpio: cdns: keep AX3000 compatible in enum

Swark Yang posted 1 patch 1 month, 3 weeks ago
Documentation/devicetree/bindings/gpio/cdns,gpio.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] dt-bindings: gpio: cdns: keep AX3000 compatible in enum
Posted by Swark Yang 1 month, 3 weeks ago
Commit e8a40b356688 ("dt-bindings: gpio: cdns: add Axiado AX3005
GPIO variant") replaced the existing single-entry enum for the AX3000
compatible with a const.

Keep the existing enum form as requested during review. This is a
formatting-only change with no effect on schema validation.

Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link:
https://lore.kernel.org/all/20260717-prudent-indefinable-labradoodle-fcaa9e@quoll/

Signed-off-by: Swark Yang <syang@axiado.com>
---
This is a follow-up to commit e8a40b356688
("dt-bindings: gpio: cdns: add Axiado AX3005 GPIO variant").

The existing single-entry enum for AX3000 was unintentionally changed
to a const. Restore the original representation as requested during
review.
---
 Documentation/devicetree/bindings/gpio/cdns,gpio.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml b/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml
index 7eacf5af6554..ee3519eba2c2 100644
--- a/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml
@@ -14,7 +14,8 @@ properties:
     oneOf:
       - const: cdns,gpio-r1p02
       - items:
-          - const: axiado,ax3000-gpio
+          - enum:
+              - axiado,ax3000-gpio
           - const: cdns,gpio-r1p02
       - items:
           - const: axiado,ax3005-gpio

---
base-commit: 6435d21cbd42fea6c66dfd4cfef7d58b9612497e
change-id: 20260805-ax3005-gpio-keep-enum-follow-up-4082c69939e4

Best regards,
-- 
Swark Yang <syang@axiado.com>
Re: [PATCH] dt-bindings: gpio: cdns: keep AX3000 compatible in enum
Posted by Krzysztof Kozlowski 1 month, 3 weeks ago
On 06/08/2026 05:55, Swark Yang wrote:
> Commit e8a40b356688 ("dt-bindings: gpio: cdns: add Axiado AX3005
> GPIO variant") replaced the existing single-entry enum for the AX3000
> compatible with a const.
> 
> Keep the existing enum form as requested during review. This is a
> formatting-only change with no effect on schema validation.
> 
> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

No, I did not suggest such patch.

I asked to make changes to YOUR patch and I replied within a few hours.

This is just churn and for sure not suggested by me as standalone commit.

Best regards,
Krzysztof
Re: [PATCH] dt-bindings: gpio: cdns: keep AX3000 compatible in enum
Posted by Swark Yang 1 month, 3 weeks ago
On 8/6/2026 2:57 PM, Krzysztof Kozlowski wrote:
> 
> No, I did not suggest such patch.
> 
> I asked to make changes to YOUR patch and I replied within a few hours.
> 
> This is just churn and for sure not suggested by me as standalone commit.
> 
> Best regards,
> Krzysztof

Understood. I misunderstood your review comment. You were asking for
the change to be made to the original patch, rather than suggesting
a standalone follow-up patch.

I should not have added the Suggested-by tag to this patch.
Sorry for the incorrect attribution.

Bartosz, would you prefer that I send a v2 without the Suggested-by tag,
or should this follow-up patch be dropped?

Best Regards,
Swark