Enable CONTEXT_ANALYSYS for s390's crypto code.

Static code checking for acquiring and releasing locks used to be done
with sparse. That was removed with [1] and replaced with a clang based
approach [2]. The new approach requires that each subsystem needs to be
explicitly enabled for checking.

Do that for s390's crypto code. In order to avoid false positives the
code has to be slightly reworked, since conditionally acquiring and
releasing locks does not work with the checker (besides that this is
sub optimal coding style).

[1] 5b63d0ae94cc ("compiler-context-analysis: Remove Sparse support")
[2] 3269701cb256 ("compiler-context-analysis: Add infrastructure for Context Analysis with Clang")

Note:

- "Pre-existing issues" reported by AI will not be addressed in the
  context of this series

Heiko Carstens (3):
  s390/crypto: Rework ctr_aes_crypt() to remove conditional locking
  s390/crypto: Rework ctr_paes_do_crypt() to remove conditional locking
  s390/crypto: Enable CONTEXT_ANALYSIS

 arch/s390/crypto/Makefile    |   2 +
 arch/s390/crypto/aes_s390.c  |  54 +++++++++++-------
 arch/s390/crypto/paes_s390.c | 104 ++++++++++++++++++++---------------
 3 files changed, 97 insertions(+), 63 deletions(-)

-- 
2.53.0

On Tue, Aug 04, 2026 at 01:37:33PM +0200, Heiko Carstens wrote:
> Enable CONTEXT_ANALYSYS for s390's crypto code.
> 
> Static code checking for acquiring and releasing locks used to be done
> with sparse. That was removed with [1] and replaced with a clang based
> approach [2]. The new approach requires that each subsystem needs to be
> explicitly enabled for checking.
> 
> Do that for s390's crypto code. In order to avoid false positives the
> code has to be slightly reworked, since conditionally acquiring and
> releasing locks does not work with the checker (besides that this is
> sub optimal coding style).
> 
> [1] 5b63d0ae94cc ("compiler-context-analysis: Remove Sparse support")
> [2] 3269701cb256 ("compiler-context-analysis: Add infrastructure for Context Analysis with Clang")
> 
> Note:
> 
> - "Pre-existing issues" reported by AI will not be addressed in the
>   context of this series
> 
> Heiko Carstens (3):
>   s390/crypto: Rework ctr_aes_crypt() to remove conditional locking
>   s390/crypto: Rework ctr_paes_do_crypt() to remove conditional locking
>   s390/crypto: Enable CONTEXT_ANALYSIS
> 
>  arch/s390/crypto/Makefile    |   2 +
>  arch/s390/crypto/aes_s390.c  |  54 +++++++++++-------
>  arch/s390/crypto/paes_s390.c | 104 ++++++++++++++++++++---------------
>  3 files changed, 97 insertions(+), 63 deletions(-)

Applied, thank you!

On Mon, Aug 17, 2026 at 04:57:08PM +0200, Vasily Gorbik wrote:
> On Tue, Aug 04, 2026 at 01:37:33PM +0200, Heiko Carstens wrote:
> > Enable CONTEXT_ANALYSYS for s390's crypto code.
...
> > Heiko Carstens (3):
> >   s390/crypto: Rework ctr_aes_crypt() to remove conditional locking
> >   s390/crypto: Rework ctr_paes_do_crypt() to remove conditional locking
> >   s390/crypto: Enable CONTEXT_ANALYSIS
> > 
> >  arch/s390/crypto/Makefile    |   2 +
> >  arch/s390/crypto/aes_s390.c  |  54 +++++++++++-------
> >  arch/s390/crypto/paes_s390.c | 104 ++++++++++++++++++++---------------
> >  3 files changed, 97 insertions(+), 63 deletions(-)
> 
> Applied, thank you!

This series was applied too early. Harald's rework should go in first, so I'm dropping this for now.

On Tue, Aug 04, 2026 at 01:37:33PM +0200, Heiko Carstens wrote:
> Enable CONTEXT_ANALYSYS for s390's crypto code.
> 
> Static code checking for acquiring and releasing locks used to be done
> with sparse. That was removed with [1] and replaced with a clang based
> approach [2]. The new approach requires that each subsystem needs to be
> explicitly enabled for checking.
> 
> Do that for s390's crypto code. In order to avoid false positives the
> code has to be slightly reworked, since conditionally acquiring and
> releasing locks does not work with the checker (besides that this is
> sub optimal coding style).
> 
> [1] 5b63d0ae94cc ("compiler-context-analysis: Remove Sparse support")
> [2] 3269701cb256 ("compiler-context-analysis: Add infrastructure for Context Analysis with Clang")
> 
> Note:
> 
> - "Pre-existing issues" reported by AI will not be addressed in the
>   context of this series
> 
> Heiko Carstens (3):
>   s390/crypto: Rework ctr_aes_crypt() to remove conditional locking
>   s390/crypto: Rework ctr_paes_do_crypt() to remove conditional locking
>   s390/crypto: Enable CONTEXT_ANALYSIS
> 
>  arch/s390/crypto/Makefile    |   2 +
>  arch/s390/crypto/aes_s390.c  |  54 +++++++++++-------
>  arch/s390/crypto/paes_s390.c | 104 ++++++++++++++++++++---------------
>  3 files changed, 97 insertions(+), 63 deletions(-)

I presume this is going through the s390 tree?

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

On 2026-08-15 02:59, Herbert Xu wrote:
> On Tue, Aug 04, 2026 at 01:37:33PM +0200, Heiko Carstens wrote:
>> Enable CONTEXT_ANALYSYS for s390's crypto code.
>> 
>> Static code checking for acquiring and releasing locks used to be done
>> with sparse. That was removed with [1] and replaced with a clang based
>> approach [2]. The new approach requires that each subsystem needs to 
>> be
>> explicitly enabled for checking.
>> 
>> Do that for s390's crypto code. In order to avoid false positives the
>> code has to be slightly reworked, since conditionally acquiring and
>> releasing locks does not work with the checker (besides that this is
>> sub optimal coding style).
>> 
>> [1] 5b63d0ae94cc ("compiler-context-analysis: Remove Sparse support")
>> [2] 3269701cb256 ("compiler-context-analysis: Add infrastructure for 
>> Context Analysis with Clang")
>> 
>> Note:
>> 
>> - "Pre-existing issues" reported by AI will not be addressed in the
>>   context of this series
>> 
>> Heiko Carstens (3):
>>   s390/crypto: Rework ctr_aes_crypt() to remove conditional locking
>>   s390/crypto: Rework ctr_paes_do_crypt() to remove conditional 
>> locking
>>   s390/crypto: Enable CONTEXT_ANALYSIS
>> 
>>  arch/s390/crypto/Makefile    |   2 +
>>  arch/s390/crypto/aes_s390.c  |  54 +++++++++++-------
>>  arch/s390/crypto/paes_s390.c | 104 
>> ++++++++++++++++++++---------------
>>  3 files changed, 97 insertions(+), 63 deletions(-)
> 
> I presume this is going through the s390 tree?
> 
> Cheers,

We can do this via s390 subsystem. I anyway wanted to suggest this.
Thanks