1. Patchew
  2. linux
  3. View series

[PATCH] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call

Hongfu Li posted 1 patch 1 month, 4 weeks ago
There is a newer version of this series
tools/testing/selftests/mm/mseal_test.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call
Posted by Hongfu Li 1 month, 4 weeks ago 
From: Hongfu Li <lihongfu@kylinos.cn>

mseal_test main() invokes test_seal_mprotect_two_vma_with_gap() twice.
The second run repeats all assertions with no benefit. Drop the
duplicate call.

Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
---
 tools/testing/selftests/mm/mseal_test.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c
index 93c2e13094d4..babc217d9dc9 100644
--- a/tools/testing/selftests/mm/mseal_test.c
+++ b/tools/testing/selftests/mm/mseal_test.c
@@ -1913,7 +1913,6 @@ int main(void)
 	test_seal_mprotect_partial_mprotect(false);
 	test_seal_mprotect_partial_mprotect(true);
 
-	test_seal_mprotect_two_vma_with_gap();
 	test_seal_mprotect_two_vma_with_gap();
 
 	test_seal_mprotect_merge(false);
-- 
2.54.0
Re: [PATCH] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call
Posted by Lorenzo Stoakes (ARM) 1 month, 4 weeks ago 
On Tue, Aug 04, 2026 at 02:24:40PM +0800, Hongfu Li wrote:
> From: Hongfu Li <lihongfu@kylinos.cn>
>
> mseal_test main() invokes test_seal_mprotect_two_vma_with_gap() twice.
> The second run repeats all assertions with no benefit. Drop the
> duplicate call.
>
> Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>

:))

LGTM so

Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>

> ---
>  tools/testing/selftests/mm/mseal_test.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c
> index 93c2e13094d4..babc217d9dc9 100644
> --- a/tools/testing/selftests/mm/mseal_test.c
> +++ b/tools/testing/selftests/mm/mseal_test.c
> @@ -1913,7 +1913,6 @@ int main(void)
>  	test_seal_mprotect_partial_mprotect(false);
>  	test_seal_mprotect_partial_mprotect(true);
>
> -	test_seal_mprotect_two_vma_with_gap();
>  	test_seal_mprotect_two_vma_with_gap();
>
>  	test_seal_mprotect_merge(false);
> --
> 2.54.0
>

--
Cheers, Lorenzo
Re: [PATCH] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call
Posted by Lorenzo Stoakes (ARM) 1 month, 4 weeks ago 
On Tue, Aug 04, 2026 at 09:20:37AM +0100, Lorenzo Stoakes (ARM) wrote:
> On Tue, Aug 04, 2026 at 02:24:40PM +0800, Hongfu Li wrote:
> > From: Hongfu Li <lihongfu@kylinos.cn>
> >
> > mseal_test main() invokes test_seal_mprotect_two_vma_with_gap() twice.
> > The second run repeats all assertions with no benefit. Drop the
> > duplicate call.
> >
> > Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
>
> :))
>
> LGTM so
>
> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>

Sorry Pedro mentioned off-list that you need to update the number of tests
specified, e.g.:

-	ksft_set_plan(88);
+	ksft_set_plan(87);

In main().

Update that and send a respin and you can attach my tag to it.

>
> > ---
> >  tools/testing/selftests/mm/mseal_test.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c
> > index 93c2e13094d4..babc217d9dc9 100644
> > --- a/tools/testing/selftests/mm/mseal_test.c
> > +++ b/tools/testing/selftests/mm/mseal_test.c
> > @@ -1913,7 +1913,6 @@ int main(void)
> >  	test_seal_mprotect_partial_mprotect(false);
> >  	test_seal_mprotect_partial_mprotect(true);
> >
> > -	test_seal_mprotect_two_vma_with_gap();
> >  	test_seal_mprotect_two_vma_with_gap();
> >
> >  	test_seal_mprotect_merge(false);
> > --
> > 2.54.0
> >
>
> --
> Cheers, Lorenzo

--
Cheers, Lorenzo
Re: [PATCH] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call
Posted by Hongfu Li 1 month, 4 weeks ago 
On 8/4/26 4:24 PM, Lorenzo Stoakes (ARM) wrote:
> On Tue, Aug 04, 2026 at 09:20:37AM +0100, Lorenzo Stoakes (ARM) wrote:
>> On Tue, Aug 04, 2026 at 02:24:40PM +0800, Hongfu Li wrote:
>>> From: Hongfu Li <lihongfu@kylinos.cn>
>>>
>>> mseal_test main() invokes test_seal_mprotect_two_vma_with_gap() twice.
>>> The second run repeats all assertions with no benefit. Drop the
>>> duplicate call.
>>>
>>> Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
>> :))
>>
>> LGTM so
>>
>> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> Sorry Pedro mentioned off-list that you need to update the number of tests
> specified, e.g.:
>
> -	ksft_set_plan(88);
> +	ksft_set_plan(87);
>
> In main().
>
> Update that and send a respin and you can attach my tag to it.
Thanks a lot for your review. I will adjust ksft_set_plan() from 88 to 
87 in main() and
send a respin carrying your Reviewed-by.

-- 
Best regards,
Hongfu
Re: [PATCH] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call
Posted by David Hildenbrand (Arm) 1 month, 4 weeks ago 
On 8/4/26 10:51, Hongfu Li wrote:
> 
> On 8/4/26 4:24 PM, Lorenzo Stoakes (ARM) wrote:
>> On Tue, Aug 04, 2026 at 09:20:37AM +0100, Lorenzo Stoakes (ARM) wrote:
>>> :))
>>>
>>> LGTM so
>>>
>>> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
>> Sorry Pedro mentioned off-list that you need to update the number of tests
>> specified, e.g.:
>>
>> -    ksft_set_plan(88);
>> +    ksft_set_plan(87);
>>
>> In main().
>>
>> Update that and send a respin and you can attach my tag to it.
> Thanks a lot for your review. I will adjust ksft_set_plan() from 88 to 87 in main() and
> send a respin carrying your Reviewed-by.
> 

Feel free to add

Acked-by: David Hildenbrand (Arm) <david@kernel.org>

to the respin.

-- 
Cheers,

David

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.