[PATCH v4 0/4] arm64: dts: qcom: hamoa-iot-evk, purwa-iot-evk: Enable M.2 Key E connector

Wei Deng posted 4 patches 1 month, 4 weeks ago
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 130 +++++++----------------------
arch/arm64/boot/dts/qcom/hamoa.dtsi        |  11 +++
arch/arm64/boot/dts/qcom/purwa-iot-evk.dts | 129 +++++++---------------------
3 files changed, 74 insertions(+), 196 deletions(-)
[PATCH v4 0/4] arm64: dts: qcom: hamoa-iot-evk, purwa-iot-evk: Enable M.2 Key E connector
Posted by Wei Deng 1 month, 4 weeks ago
Describe the PCIe M.2 Key E connector on the Hamoa and Purwa IoT EVKs.
The two boards share the same M.2 wiring: PCIe for Wi-Fi (via
pcie4_port0) and UART for Bluetooth (via uart14). Purwa inherits
hamoa.dtsi through purwa.dtsi, so the endpoint stub labels and the
PCIe root port compatible added in this series apply to both boards.

Only the UART BT path is described here. USB BT variants of the same
M.2 slot need the USB core to acquire the M.2 pwrseq target, which is
being added by Chen-Yu Tsai's "arm64: mediatek: Add M.2 E-key slot on
Chromebooks" series:
https://lore.kernel.org/all/20260724084328.3943997-1-wenst@chromium.org/
A follow-up will wire usb_2 port@1 to the wifi-bt-connector node once
that lands.

The pcie-m2 sub-ID patch that was part of the original series has been
sent independently and is already applied:
https://lore.kernel.org/all/20260724-hamoa-m2-sub-id-v2-v3-1-af97de70bbbe@oss.qualcomm.com/

Changes in v4:
- Drop the usb_2 port numbering hunk from patch 1/4 (was "hamoa:
  Number usb_2 HS port and add M.2 endpoint stubs"). port@1 =
  usb_2_m2_ep hit the snps,dwc3-common.yaml "port@1 = SS" schema and
  was NAK'd by Konrad; the outstanding binding question is discussed
  in Konrad's replies on Chen-Yu's V6 series (patches 6 and 11):
  https://lore.kernel.org/all/c6526ba0-be08-46c6-a501-1b161939657c@oss.qualcomm.com/
  Patch 1/4 now only adds the uart14_ep and pcie4_port0_ep endpoint
  stubs (Konrad had asked for these as label references).
- Drop port@2 (USB) from the hamoa-iot-evk wifi-bt-connector node.
  The connector only advertises PCIe (port@0) and UART (port@3).
- Drop the &usb_2_dwc3_hs endpoint override.
- Add new patch 4/4 for purwa-iot-evk.dts, reusing the same connector
  layout and the labels inherited via hamoa.dtsi.
- Drop "Depends on:" — this series is now independent of Chen-Yu's
  MediaTek Chromebook series.
- Link to v3: https://lore.kernel.org/r/20260729-hamoa-m2-dts-v2-v3-0-4d7ef9274575@oss.qualcomm.com

Changes in v3:
- patch 1: add uart14_ep, usb_2_m2_ep and pcie4_port0_ep stub endpoints
  in hamoa.dtsi so board DTS can reference them by label directly;
  remove superfluous comment (Konrad).
- patch 3: use &uart14_ep, &usb_2_m2_ep and &pcie4_port0_ep label
  references instead of re-defining port hierarchy in board DTS
  (Konrad).
- Link to v2: https://lore.kernel.org/r/20260723-hamoa-m2-dts-v2-v2-0-82254ac101fb@oss.qualcomm.com

Changes in v2:
- Split patch 1/3 of the original series into two commits (Dmitry).
- Add usb_2 HS port@0 (new patch 1/3) to pair with M.2 USB port@1.
- In patch 3/3: rename pcie4port0_ep -> pcie4_port0_ep (Konrad); add
  port@2 for the USB BT variant; remove unused vreg_wcn_0p95 /
  vreg_wcn_1p9 (sashiko). Konrad's v1 Reviewed-by is not carried as
  the new port@2 endpoint and vreg cleanup were not part of the v1
  review scope.
- Drop patch 3/3 of v1 (W_DISABLE2# else-branch); the Chen-Yu series
  handles it via USB pwrseq (Mani).
- Link to v1: https://lore.kernel.org/r/20260709-fix-hamoa-m2-w-disable2-v1-0-5e725091266a@oss.qualcomm.com

Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
---
Wei Deng (4):
      arm64: dts: qcom: hamoa: Add graph port/endpoint anchors to pcie4_port0 and uart14
      arm64: dts: qcom: hamoa: Add compatible to the PCIe Root Port
      arm64: dts: qcom: hamoa-iot-evk: Describe the PCIe M.2 Key E connector
      arm64: dts: qcom: purwa-iot-evk: Describe the PCIe M.2 Key E connector

 arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 130 +++++++----------------------
 arch/arm64/boot/dts/qcom/hamoa.dtsi        |  11 +++
 arch/arm64/boot/dts/qcom/purwa-iot-evk.dts | 129 +++++++---------------------
 3 files changed, 74 insertions(+), 196 deletions(-)
---
base-commit: 290aaf24a551d5a0dce037e3fab30820f9113a10
change-id: 20260723-hamoa-m2-dts-v2-2067c7421569

Best regards,
-- 
Wei Deng <wei.deng@oss.qualcomm.com>

Re: [PATCH v4 0/4] arm64: dts: qcom: hamoa-iot-evk, purwa-iot-evk: Enable M.2 Key E connector
Posted by Bjorn Andersson 1 month ago
On Tue, 04 Aug 2026 18:02:24 +0530, Wei Deng wrote:
> Describe the PCIe M.2 Key E connector on the Hamoa and Purwa IoT EVKs.
> The two boards share the same M.2 wiring: PCIe for Wi-Fi (via
> pcie4_port0) and UART for Bluetooth (via uart14). Purwa inherits
> hamoa.dtsi through purwa.dtsi, so the endpoint stub labels and the
> PCIe root port compatible added in this series apply to both boards.
> 
> Only the UART BT path is described here. USB BT variants of the same
> M.2 slot need the USB core to acquire the M.2 pwrseq target, which is
> being added by Chen-Yu Tsai's "arm64: mediatek: Add M.2 E-key slot on
> Chromebooks" series:
> https://lore.kernel.org/all/20260724084328.3943997-1-wenst@chromium.org/
> A follow-up will wire usb_2 port@1 to the wifi-bt-connector node once
> that lands.
> 
> [...]

Applied, thanks!

[1/4] arm64: dts: qcom: hamoa: Add graph port/endpoint anchors to pcie4_port0 and uart14
      commit: 014501d141ed5b94bff20b468f9da1110e4c7f7e
[2/4] arm64: dts: qcom: hamoa: Add compatible to the PCIe Root Port
      commit: 3991b7a78c8b4930140b61da6b0dd562126c6c6b
[3/4] arm64: dts: qcom: hamoa-iot-evk: Describe the PCIe M.2 Key E connector
      commit: 394a7a01c5faea0924207105ab0bf83b9d2f64f7
[4/4] arm64: dts: qcom: purwa-iot-evk: Describe the PCIe M.2 Key E connector
      commit: ced480bd5343cc17c1741792f2bca026f2825793

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>
Re: [PATCH v4 0/4] arm64: dts: qcom: hamoa-iot-evk, purwa-iot-evk: Enable M.2 Key E connector
Posted by Manivannan Sadhasivam 1 month ago
On Tue, Aug 04, 2026 at 06:02:24PM +0530, Wei Deng wrote:
> Describe the PCIe M.2 Key E connector on the Hamoa and Purwa IoT EVKs.
> The two boards share the same M.2 wiring: PCIe for Wi-Fi (via
> pcie4_port0) and UART for Bluetooth (via uart14). Purwa inherits
> hamoa.dtsi through purwa.dtsi, so the endpoint stub labels and the
> PCIe root port compatible added in this series apply to both boards.
> 
> Only the UART BT path is described here. USB BT variants of the same
> M.2 slot need the USB core to acquire the M.2 pwrseq target, which is
> being added by Chen-Yu Tsai's "arm64: mediatek: Add M.2 E-key slot on
> Chromebooks" series:
> https://lore.kernel.org/all/20260724084328.3943997-1-wenst@chromium.org/
> A follow-up will wire usb_2 port@1 to the wifi-bt-connector node once
> that lands.
> 
> The pcie-m2 sub-ID patch that was part of the original series has been
> sent independently and is already applied:
> https://lore.kernel.org/all/20260724-hamoa-m2-sub-id-v2-v3-1-af97de70bbbe@oss.qualcomm.com/
> 

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>

- Mani

-- 
மணிவண்ணன் சதாசிவம்