checkpatch.pl: adapt to new Assisted-by: format

[PATCH] checkpatch.pl: adapt to new Assisted-by: format

Posted by Jeff Layton 1 month, 4 weeks ago

There is a new format for the 'Assisted-by:' tag. Change checkpatch.pl
to just check that it has a value rather than testing for a specific
format.

Assisted-by: LLM
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
This is a companion patch to the one to change the format in
Documentation/. See:

    https://lore.kernel.org/workflows/87qzkuahlr.fsf@trenco.lwn.net/
---
 scripts/checkpatch.pl | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2b7a42bbdd94..7961d9584bc5 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3124,11 +3124,12 @@ sub process {
 				}
 			}
 
-			# Assisted-by uses AGENT_NAME:MODEL_VERSION format, not email
+			# Assisted-by uses a free-form value (e.g. "LLM"), not an
+			# email address, so skip the email format checks below.
 			if ($sign_off =~ /^Assisted-by:/i) {
-				if ($email !~ /^\S+:\S+/) {
+				if ($email =~ /^\s*$/) {
 					WARN("BAD_SIGN_OFF",
-					     "Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format\n" . $herecurr);
+					     "Assisted-by requires a value\n" . $herecurr);
 				}
 				next;
 			}

---
base-commit: 848acc8ffe1b7cd5f1bf427b93069becfebc2c9d
change-id: 20260804-checkpatch-87402d649095

Best regards,
-- 
Jeff Layton <jlayton@kernel.org>

Re: [PATCH] checkpatch.pl: adapt to new Assisted-by: format

Posted by Jonathan Corbet 1 month, 3 weeks ago

Jeff Layton <jlayton@kernel.org> writes:

> There is a new format for the 'Assisted-by:' tag. Change checkpatch.pl
> to just check that it has a value rather than testing for a specific
> format.
>
> Assisted-by: LLM
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> This is a companion patch to the one to change the format in
> Documentation/. See:
>
>     https://lore.kernel.org/workflows/87qzkuahlr.fsf@trenco.lwn.net/
> ---
>  scripts/checkpatch.pl | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Applied... we don't have a Sure-whatever-by tag, so I didn't add
Joe's...

Thanks,

jon

Re: [PATCH] checkpatch.pl: adapt to new Assisted-by: format

Posted by Joe Perches 1 month, 4 weeks ago

On Tue, 2026-08-04 at 12:13 -0400, Jeff Layton wrote:
> There is a new format for the 'Assisted-by:' tag. Change checkpatch.pl
> to just check that it has a value rather than testing for a specific
> format.
> 
> Assisted-by: LLM

Did an LLM really help produce this?  Why?

> Signed-off-by: Jeff Layton <[jlayton@kernel.org](mailto:jlayton@kernel.org)>
> ---
> This is a companion patch to the one to change the format in
> Documentation/. See:
> 
>     [https://lore.kernel.org/workflows/87qzkuahlr.fsf@trenco.lwn.net/](https://lore.kernel.org/workflows/87qzkuahlr.fsf@trenco.lwn.net/)
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3124,11 +3124,12 @@ sub process {
>  				}
>  			}
>  
> -			# Assisted-by uses AGENT_NAME:MODEL_VERSION format, not email
> +			# Assisted-by uses a free-form value (e.g. "LLM"), not an
> +			# email address, so skip the email format checks below.
>  			if ($sign_off =~ /^Assisted-by:/i) {And
> -				if ($email !~ /^\S+:\S+/) {
> +				if ($email =~ /^\s*$/) {
>  					WARN("BAD_SIGN_OFF",
> -					     "Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format\n" . $herecurr);
> +					     "Assisted-by requires a value\n" . $herecurr);
>  				}
>  				next;
>  			}
> 
[]
> Best regards,

Sure, whatever.

cheers

Re: [PATCH] checkpatch.pl: adapt to new Assisted-by: format

Posted by Jeff Layton 1 month, 4 weeks ago

On Tue, 2026-08-04 at 09:23 -0700, Joe Perches wrote:
> On Tue, 2026-08-04 at 12:13 -0400, Jeff Layton wrote:
> > There is a new format for the 'Assisted-by:' tag. Change checkpatch.pl
> > to just check that it has a value rather than testing for a specific
> > format.
> > 
> > Assisted-by: LLM
> 
> Did an LLM really help produce this?  Why?
> 

Why not? It was simple to have it do it, and my perl skills are a bit
rusty. I don't love typing, fwiw...

> > Signed-off-by: Jeff Layton <[jlayton@kernel.org](mailto:jlayton@kernel.org)>
> > ---
> > This is a companion patch to the one to change the format in
> > Documentation/. See:
> > 
> >     [https://lore.kernel.org/workflows/87qzkuahlr.fsf@trenco.lwn.net/](https://lore.kernel.org/workflows/87qzkuahlr.fsf@trenco.lwn.net/)
> []
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -3124,11 +3124,12 @@ sub process {
> >  				}
> >  			}
> >  
> > -			# Assisted-by uses AGENT_NAME:MODEL_VERSION format, not email
> > +			# Assisted-by uses a free-form value (e.g. "LLM"), not an
> > +			# email address, so skip the email format checks below.
> >  			if ($sign_off =~ /^Assisted-by:/i) {And
> > -				if ($email !~ /^\S+:\S+/) {
> > +				if ($email =~ /^\s*$/) {
> >  					WARN("BAD_SIGN_OFF",
> > -					     "Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format\n" . $herecurr);
> > +					     "Assisted-by requires a value\n" . $herecurr);
> >  				}
> >  				next;
> >  			}
> > 
> []
> > Best regards,
> 
> Sure, whatever.
> 
> cheers

-- 
Jeff Layton <jlayton@kernel.org>