drivers/net/wireless/ath/ath12k/dp_rx.c | 21 --------------------- drivers/net/wireless/ath/ath12k/dp_rx.h | 3 --- 2 files changed, 24 deletions(-)
ath12k_dp_rx_h_find_link_peer() is no longer referenced anywhere,
remove the unused helper and its declaration to avoid dead code.
Tested-on: QCC2072 hw1.0 PCI CI_WLAN.COL.1.0.c2-00229.1-QCACOLSWPL_V1_TO_SILICON-1
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/dp_rx.c | 21 ---------------------
drivers/net/wireless/ath/ath12k/dp_rx.h | 3 ---
2 files changed, 24 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/dp_rx.c b/drivers/net/wireless/ath/ath12k/dp_rx.c
index 8fa0e90b4531..23d1a6d39d41 100644
--- a/drivers/net/wireless/ath/ath12k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath12k/dp_rx.c
@@ -1200,27 +1200,6 @@ void ath12k_dp_rx_h_undecap(struct ath12k_pdev_dp *dp_pdev, struct sk_buff *msdu
}
EXPORT_SYMBOL(ath12k_dp_rx_h_undecap);
-struct ath12k_dp_link_peer *
-ath12k_dp_rx_h_find_link_peer(struct ath12k_pdev_dp *dp_pdev, struct sk_buff *msdu,
- struct hal_rx_desc_data *rx_info)
-{
- struct ath12k_skb_rxcb *rxcb = ATH12K_SKB_RXCB(msdu);
- struct ath12k_dp_link_peer *peer = NULL;
- struct ath12k_dp *dp = dp_pdev->dp;
-
- lockdep_assert_held(&dp->dp_lock);
-
- peer = ath12k_dp_link_peer_find_by_peerid(dp_pdev, rxcb->peer_id);
-
- if (peer)
- return peer;
-
- if (rx_info->addr2_present)
- peer = ath12k_dp_link_peer_find_by_addr(dp, rx_info->addr2);
-
- return peer;
-}
-
static void ath12k_dp_rx_h_rate(struct ath12k_pdev_dp *dp_pdev,
struct hal_rx_desc_data *rx_info)
{
diff --git a/drivers/net/wireless/ath/ath12k/dp_rx.h b/drivers/net/wireless/ath/ath12k/dp_rx.h
index 0660db070e92..82700474548a 100644
--- a/drivers/net/wireless/ath/ath12k/dp_rx.h
+++ b/drivers/net/wireless/ath/ath12k/dp_rx.h
@@ -237,9 +237,6 @@ int ath12k_dp_rx_peer_frag_setup(struct ath12k *ar, const u8 *peer_mac, int vdev
u8 ath12k_dp_rx_h_l3pad(struct ath12k_base *ab,
struct hal_rx_desc *desc);
-struct ath12k_dp_link_peer *
-ath12k_dp_rx_h_find_link_peer(struct ath12k_pdev_dp *dp_pdev, struct sk_buff *msdu,
- struct hal_rx_desc_data *rx_info);
u8 ath12k_dp_rx_h_decap_type(struct ath12k_base *ab,
struct hal_rx_desc *desc);
u32 ath12k_dp_rx_h_mpdu_err(struct ath12k_base *ab,
base-commit: 691e5e43b2aa5da35b044532845a3b230e540894
--
2.34.1
On Mon, 03 Aug 2026 09:05:32 +0800, Miaoqing Pan wrote:
> ath12k_dp_rx_h_find_link_peer() is no longer referenced anywhere,
> remove the unused helper and its declaration to avoid dead code.
>
> Tested-on: QCC2072 hw1.0 PCI CI_WLAN.COL.1.0.c2-00229.1-QCACOLSWPL_V1_TO_SILICON-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
>
>
> [...]
Applied, thanks!
[1/1] wifi: ath12k: remove unused ath12k_dp_rx_h_find_link_peer()
commit: e1ef274a49873a9545b51e36f1f1d25707372872
Best regards,
--
Jeff Johnson <jeff.johnson@oss.qualcomm.com>
On 8/3/2026 6:35 AM, Miaoqing Pan wrote: > ath12k_dp_rx_h_find_link_peer() is no longer referenced anywhere, > remove the unused helper and its declaration to avoid dead code. > > Tested-on: QCC2072 hw1.0 PCI CI_WLAN.COL.1.0.c2-00229.1-QCACOLSWPL_V1_TO_SILICON-1 > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3 > > Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com> Guess Tested-on can removed in pending if needed so, Reviewed-by: Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>
On 8/3/2026 9:05 AM, Miaoqing Pan wrote: > ath12k_dp_rx_h_find_link_peer() is no longer referenced anywhere, > remove the unused helper and its declaration to avoid dead code. > > Tested-on: QCC2072 hw1.0 PCI CI_WLAN.COL.1.0.c2-00229.1-QCACOLSWPL_V1_TO_SILICON-1 is it OK to use engineering build in the Tested-on: tag ?
On 8/2/2026 6:54 PM, Baochen Qiang wrote: > > > On 8/3/2026 9:05 AM, Miaoqing Pan wrote: >> ath12k_dp_rx_h_find_link_peer() is no longer referenced anywhere, >> remove the unused helper and its declaration to avoid dead code. >> >> Tested-on: QCC2072 hw1.0 PCI CI_WLAN.COL.1.0.c2-00229.1-QCACOLSWPL_V1_TO_SILICON-1 > > is it OK to use engineering build in the Tested-on: tag ? > Ideally we should test with upstream firmware, but for this case compile test would be sufficient. /jeff
© 2016 - 2026 Red Hat, Inc.