1. Patchew
  2. linux
  3. View series

[PATCH] mips: econet: fix unmet dependencies for ECONET

Julian Braha posted 1 patch 2 months ago
There is a newer version of this series
arch/mips/Kconfig | 2 ++
1 file changed, 2 insertions(+)
[PATCH] mips: econet: fix unmet dependencies for ECONET
Posted by Julian Braha 2 months ago 
ECONET selects EARLY_PRINTK_8250, SERIAL_OF_PLATFORM, and SERIAL_8250
without ensuring their dependencies, EARLY_PRINTK and TTY are met. This
causes unmet dependencies:

WARNING: unmet direct dependencies detected for SERIAL_8250
  Depends on [n]: TTY [=n] && HAS_IOMEM [=y] && !S390
  Selected by [y]:
  - ECONET [=y]

WARNING: unmet direct dependencies detected for EARLY_PRINTK_8250
  Depends on [n]: EARLY_PRINTK [=n] && USE_GENERIC_EARLY_PRINTK_8250 [=y]
  Selected by [y]:
  - ECONET [=y]

WARNING: unmet direct dependencies detected for SERIAL_OF_PLATFORM
  Depends on [n]: TTY [=n] && HAS_IOMEM [=y] && SERIAL_8250 [=y] && OF [=y]
  Selected by [y]:
  - ECONET [=y]

Let's select the necessary dependencies, TTY and EARLY_PRINTK, as other
similar architecture options do.

These unmet dependencies were found by kconfirm, a static analysis tool for
Kconfig.

Fixes: 79ee1d20e37c ("mips: econet: Fix incorrect Kconfig dependencies")
Fixes: 35fb26f94dfa ("mips: Add EcoNet MIPS platform support")
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 arch/mips/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index a06f24317306..2423a6050088 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -397,8 +397,10 @@ config ECONET
 	select BOOT_RAW
 	select CPU_BIG_ENDIAN
 	select DEBUG_ZBOOT if DEBUG_KERNEL
+	select EARLY_PRINTK
 	select EARLY_PRINTK_8250
 	select ECONET_EN751221_TIMER
+	select TTY
 	select SERIAL_8250
 	select SERIAL_OF_PLATFORM
 	select SYS_SUPPORTS_BIG_ENDIAN
-- 
2.55.0
Re: [PATCH] mips: econet: fix unmet dependencies for ECONET
Posted by Arnd Bergmann 2 months ago 
On Sun, Aug 2, 2026, at 18:15, Julian Braha wrote:
> ECONET selects EARLY_PRINTK_8250, SERIAL_OF_PLATFORM, and SERIAL_8250
> without ensuring their dependencies, EARLY_PRINTK and TTY are met. This
> causes unmet dependencies:
>
> WARNING: unmet direct dependencies detected for SERIAL_8250
>   Depends on [n]: TTY [=n] && HAS_IOMEM [=y] && !S390
>   Selected by [y]:
>   - ECONET [=y]
>
> WARNING: unmet direct dependencies detected for EARLY_PRINTK_8250
>   Depends on [n]: EARLY_PRINTK [=n] && USE_GENERIC_EARLY_PRINTK_8250 [=y]
>   Selected by [y]:
>   - ECONET [=y]
>
> WARNING: unmet direct dependencies detected for SERIAL_OF_PLATFORM
>   Depends on [n]: TTY [=n] && HAS_IOMEM [=y] && SERIAL_8250 [=y] && OF [=y]
>   Selected by [y]:
>   - ECONET [=y]
>
> Let's select the necessary dependencies, TTY and EARLY_PRINTK, as other
> similar architecture options do.
>
> These unmet dependencies were found by kconfirm, a static analysis tool for
> Kconfig.

I think this platform has too many 'select' that are not helpful here
and should be removed instead.

> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index a06f24317306..2423a6050088 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -397,8 +397,10 @@ config ECONET
>  	select BOOT_RAW
>  	select CPU_BIG_ENDIAN

CPU_BIG_ENDIAN is automatically set here because of the
missing SYS_SUPPORTS_LITTLE_ENDIAN

>  	select DEBUG_ZBOOT if DEBUG_KERNEL
> +	select EARLY_PRINTK
>  	select EARLY_PRINTK_8250

There is no need to force EARLY_PRINTK_8250, you should be
able to build an ECONET kernel without any console at all.

>  	select ECONET_EN751221_TIMER
> +	select TTY
>  	select SERIAL_8250
>  	select SERIAL_OF_PLATFORM

No need to select SERIAL_8250 or SERIAL_OF_PLATFORM either,
both can be turned on in the defconfig.

     Arnd
Re: [PATCH] mips: econet: fix unmet dependencies for ECONET
Posted by Thomas Bogendoerfer 1 month, 4 weeks ago 
On Sun, Aug 02, 2026 at 07:41:45PM +0200, Arnd Bergmann wrote:
> On Sun, Aug 2, 2026, at 18:15, Julian Braha wrote:
> > ECONET selects EARLY_PRINTK_8250, SERIAL_OF_PLATFORM, and SERIAL_8250
> > without ensuring their dependencies, EARLY_PRINTK and TTY are met. This
> > causes unmet dependencies:
> >
> > WARNING: unmet direct dependencies detected for SERIAL_8250
> >   Depends on [n]: TTY [=n] && HAS_IOMEM [=y] && !S390
> >   Selected by [y]:
> >   - ECONET [=y]
> >
> > WARNING: unmet direct dependencies detected for EARLY_PRINTK_8250
> >   Depends on [n]: EARLY_PRINTK [=n] && USE_GENERIC_EARLY_PRINTK_8250 [=y]
> >   Selected by [y]:
> >   - ECONET [=y]
> >
> > WARNING: unmet direct dependencies detected for SERIAL_OF_PLATFORM
> >   Depends on [n]: TTY [=n] && HAS_IOMEM [=y] && SERIAL_8250 [=y] && OF [=y]
> >   Selected by [y]:
> >   - ECONET [=y]
> >
> > Let's select the necessary dependencies, TTY and EARLY_PRINTK, as other
> > similar architecture options do.
> >
> > These unmet dependencies were found by kconfirm, a static analysis tool for
> > Kconfig.
> 
> I think this platform has too many 'select' that are not helpful here
> and should be removed instead.
> 
> > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > index a06f24317306..2423a6050088 100644
> > --- a/arch/mips/Kconfig
> > +++ b/arch/mips/Kconfig
> > @@ -397,8 +397,10 @@ config ECONET
> >  	select BOOT_RAW
> >  	select CPU_BIG_ENDIAN
> 
> CPU_BIG_ENDIAN is automatically set here because of the
> missing SYS_SUPPORTS_LITTLE_ENDIAN

there is already a patch from Julian, which removes this select. I've
applied it a couple of minutes ago.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.