iio: humidity: htu21: Fix SYMBOLIC_PERMS chekcpatch warning

[PATCH] iio: humidity: htu21: Fix SYMBOLIC_PERMS chekcpatch warning

Posted by Adi Nata 2 months ago

Checkpatch warning:

WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
+static IIO_DEVICE_ATTR(battery_low, S_IRUGO,

WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'.
+static IIO_DEVICE_ATTR(heater_enable, S_IRUGO | S_IWUSR,

Signed-off-by: Adi Nata <adinata.softwareengineer@gmail.com>
---
 drivers/iio/humidity/htu21.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/humidity/htu21.c b/drivers/iio/humidity/htu21.c
index a9dbf08b4f1a..fe7192d142ec 100644
--- a/drivers/iio/humidity/htu21.c
+++ b/drivers/iio/humidity/htu21.c
@@ -154,9 +154,9 @@ static ssize_t htu21_write_heater(struct device *dev,
 }
 
 static IIO_CONST_ATTR_SAMP_FREQ_AVAIL(htu21_show_samp_freq);
-static IIO_DEVICE_ATTR(battery_low, S_IRUGO,
+static IIO_DEVICE_ATTR(battery_low, 0444,
 		       htu21_show_battery_low, NULL, 0);
-static IIO_DEVICE_ATTR(heater_enable, S_IRUGO | S_IWUSR,
+static IIO_DEVICE_ATTR(heater_enable, 0644,
 		       htu21_show_heater, htu21_write_heater, 0);
 
 static struct attribute *htu21_attributes[] = {
-- 
2.47.3

Re: [PATCH] iio: humidity: htu21: Fix SYMBOLIC_PERMS chekcpatch warning

Posted by Andy Shevchenko 1 month, 3 weeks ago

On Sun, Aug 02, 2026 at 09:23:26AM +0800, Adi Nata wrote:
> Checkpatch warning:
> 
> WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
> +static IIO_DEVICE_ATTR(battery_low, S_IRUGO,
> 
> WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'.
> +static IIO_DEVICE_ATTR(heater_enable, S_IRUGO | S_IWUSR,

>  static IIO_CONST_ATTR_SAMP_FREQ_AVAIL(htu21_show_samp_freq);
> -static IIO_DEVICE_ATTR(battery_low, S_IRUGO,
> +static IIO_DEVICE_ATTR(battery_low, 0444,
>  		       htu21_show_battery_low, NULL, 0);
> -static IIO_DEVICE_ATTR(heater_enable, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(heater_enable, 0644,
>  		       htu21_show_heater, htu21_write_heater, 0);

What's wrong with IIO_DEVICE_ATTR_RW()?

Same comment to all patches of a kind from you.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: humidity: htu21: Fix SYMBOLIC_PERMS chekcpatch warning

Posted by Jonathan Cameron 2 months ago

On Sun,  2 Aug 2026 09:23:26 +0800
Adi Nata <adinata.softwareengineer@gmail.com> wrote:

> Checkpatch warning:
> 
> WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
> +static IIO_DEVICE_ATTR(battery_low, S_IRUGO,
> 
> WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'.
> +static IIO_DEVICE_ATTR(heater_enable, S_IRUGO | S_IWUSR,

Would be nice to have some information on why they are not
preferred as part of the patch description.

> 
> Signed-off-by: Adi Nata <adinata.softwareengineer@gmail.com>
> ---
>  drivers/iio/humidity/htu21.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/humidity/htu21.c b/drivers/iio/humidity/htu21.c
> index a9dbf08b4f1a..fe7192d142ec 100644
> --- a/drivers/iio/humidity/htu21.c
> +++ b/drivers/iio/humidity/htu21.c
> @@ -154,9 +154,9 @@ static ssize_t htu21_write_heater(struct device *dev,
>  }
>  
>  static IIO_CONST_ATTR_SAMP_FREQ_AVAIL(htu21_show_samp_freq);
> -static IIO_DEVICE_ATTR(battery_low, S_IRUGO,
> +static IIO_DEVICE_ATTR(battery_low, 0444,
>  		       htu21_show_battery_low, NULL, 0);

Now fits on one line.



> -static IIO_DEVICE_ATTR(heater_enable, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(heater_enable, 0644,
>  		       htu21_show_heater, htu21_write_heater, 0);
I don't mind having this one on a single line as well even though it is
a bit over the 80 chars soft limit at around 84 chars.

static IIO_DEVICE_ATTR(heater_enable, 0644, htu21_show_heater, htu21_write_heater, 0);

>  
>  static struct attribute *htu21_attributes[] = {

Re: [PATCH] iio: humidity: htu21: Fix SYMBOLIC_PERMS chekcpatch warning

Posted by Uwe Kleine-König 2 months ago

Hello,

$Subject ~= s/chekc/check/

Best regards
Uwe