[v1] Input: atkbd - skip deactivate for Xiaomi Book Pro 14's internal keyboard

[PATCH] Input: atkbd - skip deactivate for Xiaomi Book Pro 14's internal keyboard

Posted by Zhefu Zhang 2 months ago

The internal keyboard of the Xiaomi Book Pro 14 does not work unless
atkbd skips deactivating it at the end of atkbd_probe().

DMI: XIAOMI Xiaomi Book Pro 14/TM2424, BIOS XMAPT4B0P0909 05/06/2026

Signed-off-by: Zhefu Zhang <a723356@gmail.com>
---
 drivers/input/keyboard/atkbd.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index 8cb4dc6fb..6c897282d 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -1938,6 +1938,14 @@ static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = {
 		},
 		.callback = atkbd_deactivate_fixup,
 	},
+	{
+		/* Xiaomi Book Pro 14 (TM2424) */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "XIAOMI"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Xiaomi Book Pro 14"),
+		},
+		.callback = atkbd_deactivate_fixup,
+	},
 	{ }
 };
 
-- 
2.55.0

[PATCH v2] Input: atkbd - skip deactivate for Xiaomi Book Pro 14's internal keyboard

Posted by Zhefu Zhang 2 months ago

The internal keyboard of the Xiaomi Book Pro 14 does not work unless
atkbd skips deactivating it at the end of atkbd_probe().

Using 'i8042.dumbkbd=1' also makes the keyboard work, but then the driver
never writes to the keyboard at all, so the Caps Lock LED is lost. The
atkbd_deactivate_fixup quirk fixes both without a boot parameter.

DMI: XIAOMI Xiaomi Book Pro 14/TM2424, BIOS XMAPT4B0P0909 05/06/2026

Signed-off-by: Zhefu Zhang <a723356@gmail.com>
Reviewed-by: Andrew Zhou <zhoulol888@gmail.com>
---
v2:
- add Andrew's Reviewed-by
- explain why i8042.dumbkbd is not an equivalent fix

Previous: https://lore.kernel.org/all/20260801101908.33838-1-a723356@gmail.com/

 drivers/input/keyboard/atkbd.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index 8cb4dc6fb..6c897282d 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -1938,6 +1938,14 @@ static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = {
 		},
 		.callback = atkbd_deactivate_fixup,
 	},
+	{
+		/* Xiaomi Book Pro 14 (TM2424) */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "XIAOMI"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Xiaomi Book Pro 14"),
+		},
+		.callback = atkbd_deactivate_fixup,
+	},
 	{ }
 };
 
-- 
2.55.0

Re: [PATCH v2] Input: atkbd - skip deactivate for Xiaomi Book Pro 14's internal keyboard

Posted by Dmitry Torokhov 2 months ago

On Sun, Aug 02, 2026 at 03:15:59PM +1200, Zhefu Zhang wrote:
> The internal keyboard of the Xiaomi Book Pro 14 does not work unless
> atkbd skips deactivating it at the end of atkbd_probe().
> 
> Using 'i8042.dumbkbd=1' also makes the keyboard work, but then the driver
> never writes to the keyboard at all, so the Caps Lock LED is lost. The
> atkbd_deactivate_fixup quirk fixes both without a boot parameter.
> 
> DMI: XIAOMI Xiaomi Book Pro 14/TM2424, BIOS XMAPT4B0P0909 05/06/2026
> 
> Signed-off-by: Zhefu Zhang <a723356@gmail.com>
> Reviewed-by: Andrew Zhou <zhoulol888@gmail.com>

Applied, thank you.

-- 
Dmitry