bus: arm-cci: fix device_node reference leak in cci_probe_ports()

[PATCH] bus: arm-cci: fix device_node reference leak in cci_probe_ports()

Ivy Lopez posted 1 patch 2 months ago

Download mbox

drivers/bus/arm-cci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH] bus: arm-cci: fix device_node reference leak in cci_probe_ports()

Posted by Ivy Lopez 2 months ago

for_each_available_child_of_node() takes a reference on each child
node in turn. When the number of matching CCI interface nodes in
the DT exceeds nb_cci_ports, the loop exits via break without
dropping the reference held on the current node, leaking it.

Add the missing of_node_put() before the break.

Signed-off-by: Ivy Lopez <skunkolee@gmail.com>
---
 drivers/bus/arm-cci.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index 7f2baf057128..5ab3d74c9ae2 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -461,8 +461,10 @@ static int cci_probe_ports(struct device_node *np)
 
 		i = nb_ace + nb_ace_lite;
 
-		if (i >= nb_cci_ports)
+		if (i >= nb_cci_ports) {
+			of_node_put(cp);
 			break;
+		}
 
 		if (of_property_read_string(cp, "interface-type",
 					&match_str)) {
-- 
2.55.0