[PATCH] fuse: use min_not_zero() in fuse_init_server_timeout()

Sang-Heon Jeon posted 1 patch 2 months ago
fs/fuse/req_timeout.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
[PATCH] fuse: use min_not_zero() in fuse_init_server_timeout()
Posted by Sang-Heon Jeon 2 months ago
fuse_init_server_timeout() limits timeout to fuse_max_req_timeout with
the same logic as min_not_zero(), and returns early exactly when the
computed timeout would be zero.

So use min_not_zero() instead and return when the computed timeout is
zero.

No functional change.

Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
 fs/fuse/req_timeout.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/fs/fuse/req_timeout.c b/fs/fuse/req_timeout.c
index 6cc6fc491343..95a1acd7bc08 100644
--- a/fs/fuse/req_timeout.c
+++ b/fs/fuse/req_timeout.c
@@ -128,18 +128,12 @@ static void set_request_timeout(struct fuse_chan *fch, unsigned int timeout)
 
 void fuse_init_server_timeout(struct fuse_chan *fch, unsigned int timeout)
 {
-	if (!timeout && !fuse_max_req_timeout && !fuse_default_req_timeout)
-		return;
-
 	if (!timeout)
 		timeout = fuse_default_req_timeout;
 
-	if (fuse_max_req_timeout) {
-		if (timeout)
-			timeout = min(fuse_max_req_timeout, timeout);
-		else
-			timeout = fuse_max_req_timeout;
-	}
+	timeout = min_not_zero(timeout, fuse_max_req_timeout);
+	if (!timeout)
+		return;
 
 	timeout = max(FUSE_TIMEOUT_TIMER_FREQ, timeout);
 
-- 
2.43.0
Re: [PATCH] fuse: use min_not_zero() in fuse_init_server_timeout()
Posted by Miklos Szeredi 1 month, 2 weeks ago
On Fri, 31 Jul 2026 at 17:47, Sang-Heon Jeon <ekffu200098@gmail.com> wrote:
>
> fuse_init_server_timeout() limits timeout to fuse_max_req_timeout with
> the same logic as min_not_zero(), and returns early exactly when the
> computed timeout would be zero.
>
> So use min_not_zero() instead and return when the computed timeout is
> zero.

Applied, thanks.

Miklos
Re: [PATCH] fuse: use min_not_zero() in fuse_init_server_timeout()
Posted by Joanne Koong 2 months ago
On Fri, Jul 31, 2026 at 8:44 AM Sang-Heon Jeon <ekffu200098@gmail.com> wrote:
>
> fuse_init_server_timeout() limits timeout to fuse_max_req_timeout with
> the same logic as min_not_zero(), and returns early exactly when the
> computed timeout would be zero.
>
> So use min_not_zero() instead and return when the computed timeout is
> zero.
>
> No functional change.
>
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>

Reviewed-by: Joanne Koong <joannelkoong@gmail.com>