[PATCH] net: eql.c: fix switch case indent

oshada imalka posted 1 patch 2 months ago
drivers/net/eql.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
[PATCH] net: eql.c: fix switch case indent
Posted by oshada imalka 2 months ago
Fix ERROR: switch and case should be at the same indent

Signed-off-by: oshada imalka <developerimalka@gmail.com>
---
 drivers/net/eql.c | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/drivers/net/eql.c b/drivers/net/eql.c
index 06083b9841ba..5fbcb9a4a31b 100644
--- a/drivers/net/eql.c
+++ b/drivers/net/eql.c
@@ -281,20 +281,20 @@ static int eql_siocdevprivate(struct net_device *dev, struct ifreq *ifr,
 		return -EOPNOTSUPP;
 
 	switch (cmd) {
-		case EQL_ENSLAVE:
-			return eql_enslave(dev, data);
-		case EQL_EMANCIPATE:
-			return eql_emancipate(dev, data);
-		case EQL_GETSLAVECFG:
-			return eql_g_slave_cfg(dev, data);
-		case EQL_SETSLAVECFG:
-			return eql_s_slave_cfg(dev, data);
-		case EQL_GETMASTRCFG:
-			return eql_g_master_cfg(dev, data);
-		case EQL_SETMASTRCFG:
-			return eql_s_master_cfg(dev, data);
-		default:
-			return -EOPNOTSUPP;
+	case EQL_ENSLAVE:
+		return eql_enslave(dev, data);
+	case EQL_EMANCIPATE:
+		return eql_emancipate(dev, data);
+	case EQL_GETSLAVECFG:
+		return eql_g_slave_cfg(dev, data);
+	case EQL_SETSLAVECFG:
+		return eql_s_slave_cfg(dev, data);
+	case EQL_GETMASTRCFG:
+		return eql_g_master_cfg(dev, data);
+	case EQL_SETMASTRCFG:
+		return eql_s_master_cfg(dev, data);
+	default:
+		return -EOPNOTSUPP;
 	}
 }
 
-- 
2.53.0
Re: [PATCH] net: eql.c: fix switch case indent
Posted by Jakub Kicinski 1 month, 4 weeks ago
On Fri, 31 Jul 2026 17:55:01 +0530 oshada imalka wrote:
> Fix ERROR: switch and case should be at the same indent

Quoting documentation:

  Clean-up patches
  ~~~~~~~~~~~~~~~~
  
  Netdev discourages patches which perform simple clean-ups, which are not in
  the context of other work. For example:
  
  * Addressing ``checkpatch.pl``, and other trivial coding style warnings
  * Addressing :ref:`Local variable ordering<rcs>` issues
  * Conversions to device-managed APIs (``devm_`` helpers)
  
  This is because it is felt that the churn that such changes produce comes
  at a greater cost than the value of such clean-ups.
    
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches