[PATCH] staging: rtl8723bs: fix several line spaces in wifi.h

Santiago Ruano Rincón posted 1 patch 13 hours ago
drivers/staging/rtl8723bs/include/wifi.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
[PATCH] staging: rtl8723bs: fix several line spaces in wifi.h
Posted by Santiago Ruano Rincón 13 hours ago
Address checkpatch.pl warnings fixing reports of type LINE_SPACING:

WARNING: Missing a blank line after declarations
CHECK: Please don't use multiple blank lines
CHECK: Please use a blank line after function/struct/union/enum
declarations

Signed-off-by: Santiago Ruano Rincón <santiagorr@riseup.net>
---
 drivers/staging/rtl8723bs/include/wifi.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/wifi.h b/drivers/staging/rtl8723bs/include/wifi.h
index d5132bc4280a..4bf158d429c6 100644
--- a/drivers/staging/rtl8723bs/include/wifi.h
+++ b/drivers/staging/rtl8723bs/include/wifi.h
@@ -163,7 +163,6 @@ enum {
 #define SetDuration(pbuf, dur) \
 	(*(__le16 *)((size_t)(pbuf) + 2) = cpu_to_le16(0xffff & (dur)))
 
-
 #define SetPriority(pbuf, tid)	\
 	(*(__le16 *)(pbuf) |= cpu_to_le16(tid & 0xf))
 
@@ -192,12 +191,15 @@ enum {
 static inline unsigned char *rtl8723bs_get_ra(unsigned char *pframe)
 {
 	unsigned char *ra;
+
 	ra = GetAddr1Ptr(pframe);
 	return ra;
 }
+
 static inline unsigned char *get_ta(unsigned char *pframe)
 {
 	unsigned char *ta;
+
 	ta = GetAddr2Ptr(pframe);
 	return ta;
 }
@@ -225,7 +227,6 @@ static inline unsigned char *get_da(unsigned char *pframe)
 	return da;
 }
 
-
 static inline unsigned char *get_sa(unsigned char *pframe)
 {
 	unsigned char *sa;
@@ -272,11 +273,11 @@ static inline unsigned char *get_hdr_bssid(unsigned char *pframe)
 	return sa;
 }
 
-
 static inline int IsFrameTypeCtrl(unsigned char *pframe)
 {
 	return GetFrameType(pframe) == WIFI_CTRL_TYPE;
 }
+
 /*-----------------------------------------------------------------------------
 			Below is for the security related definition
 ------------------------------------------------------------------------------*/
@@ -335,7 +336,6 @@ struct ieee80211_ht_addt_info {
 	unsigned char basic_set[16];
 } __packed;
 
-
 struct HT_caps_element {
 	union {
 		struct {
-- 
2.53.0

Re: [PATCH] staging: rtl8723bs: fix several line spaces in wifi.h
Posted by Nikolay Kulikov 11 hours ago
On Thu, Jul 23, 2026 at 12:35:21PM -0300, Santiago Ruano Rincón wrote:
> Address checkpatch.pl warnings fixing reports of type LINE_SPACING:
> 
> WARNING: Missing a blank line after declarations
> CHECK: Please don't use multiple blank lines
> CHECK: Please use a blank line after function/struct/union/enum
> declarations
> 
> Signed-off-by: Santiago Ruano Rincón <santiagorr@riseup.net>

Looks good to me.

Reviewed-by: Nikolay Kulikov <nikolayof23@gmail.com>


Thanks,
Nikolay