[PATCH] igc: Remove unreachable break after return

Hungyu Lin posted 1 patch 1 day, 14 hours ago
drivers/net/ethernet/intel/igc/igc_main.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] igc: Remove unreachable break after return
Posted by Hungyu Lin 1 day, 14 hours ago
The break statement immediately following the return statement is
unreachable and can never be executed.

Remove the redundant break statement.

No functional change intended.

Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
 drivers/net/ethernet/intel/igc/igc_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index 2c9e2dfd8499..6252d4b68f88 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -2528,7 +2528,6 @@ static int __igc_xdp_run_prog(struct igc_adapter *adapter,
 		if (xdp_do_redirect(adapter->netdev, xdp, prog) < 0)
 			goto out_failure;
 		return IGC_XDP_REDIRECT;
-		break;
 	default:
 		bpf_warn_invalid_xdp_action(adapter->netdev, prog, act);
 		fallthrough;
-- 
2.43.0
Re: [PATCH] igc: Remove unreachable break after return
Posted by Joe Damato 1 day, 8 hours ago
On Thu, Jul 23, 2026 at 07:04:51AM +0000, Hungyu Lin wrote:
> The break statement immediately following the return statement is
> unreachable and can never be executed.
> 
> Remove the redundant break statement.
> 
> No functional change intended.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
>  drivers/net/ethernet/intel/igc/igc_main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index 2c9e2dfd8499..6252d4b68f88 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -2528,7 +2528,6 @@ static int __igc_xdp_run_prog(struct igc_adapter *adapter,
>  		if (xdp_do_redirect(adapter->netdev, xdp, prog) < 0)
>  			goto out_failure;
>  		return IGC_XDP_REDIRECT;
> -		break;

Hm, from Documentation/process/maintainer-netdev.rst:

  Netdev discourages patches which perform simple clean-ups, which are not in
  the context of other work.

I think this patch probably meets the definition of patches which are
discouraged.