From: Michael Gur <michaelgur@nvidia.com>
Decouple RoCE acceleration counters exposure from the roce_accl device
cap. The device cap is intended to protect the access to the roce_accl
register and was disabled on VFs for that purpose.
Reading the acceleration counters, however, does not involve that
register, the counters are read-only statistics that carry no
configuration risk. Gating their exposure on the capability therefore
needlessly hides useful diagnostic data on VFs.
Expose the counters on all functions regardless of the capability.
Signed-off-by: Michael Gur <michaelgur@nvidia.com>
Reviewed-by: Chiara Meiohas <cmeiohas@nvidia.com>
Signed-off-by: Edward Srouji <edwards@nvidia.com>
---
drivers/infiniband/hw/mlx5/counters.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/counters.c b/drivers/infiniband/hw/mlx5/counters.c
index 5a79e834ddea0c15b0b634a13de66acc1adff0cc..2250b195571c5c9ac92e924029e1e2faaaff1046 100644
--- a/drivers/infiniband/hw/mlx5/counters.c
+++ b/drivers/infiniband/hw/mlx5/counters.c
@@ -742,11 +742,9 @@ static void mlx5_ib_fill_counters(struct mlx5_ib_dev *dev,
names = is_vport ? vport_roce_accl_cnts : roce_accl_cnts;
size = is_vport ? ARRAY_SIZE(vport_roce_accl_cnts) :
ARRAY_SIZE(roce_accl_cnts);
- if (MLX5_CAP_GEN(dev->mdev, roce_accl)) {
- for (i = 0; i < size; i++, j++) {
- descs[j].name = names[i].name;
- offsets[j] = names[i].offset;
- }
+ for (i = 0; i < size; i++, j++) {
+ descs[j].name = names[i].name;
+ offsets[j] = names[i].offset;
}
if (is_vport)
@@ -826,8 +824,7 @@ static int __mlx5_ib_alloc_counters(struct mlx5_ib_dev *dev,
size = is_vport ? ARRAY_SIZE(vport_roce_accl_cnts) :
ARRAY_SIZE(roce_accl_cnts);
- if (MLX5_CAP_GEN(dev->mdev, roce_accl))
- num_counters += size;
+ num_counters += size;
cnts->num_q_counters = num_counters;
---
base-commit: 9b66c9af7172ffcf727214fa0ebe9a5e1ed6eb16
change-id: 20260723-expose-roce-accl-counters-8063ccc3f658
Best regards,
--
Edward Srouji <edwards@nvidia.com>