[v2] soc: ti: wkup_m3_ipc: Remove redundant dev_err()

[PATCH v2] soc: ti: wkup_m3_ipc: Remove redundant dev_err()

Posted by Pan Chuang 2 days, 20 hours ago

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
Reviewed-by: Hari Prasath Gujulan Elango <gehariprasath@ti.com>
---
 drivers/soc/ti/wkup_m3_ipc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
index 5845fc652adc..f8640cdc2a21 100644
--- a/drivers/soc/ti/wkup_m3_ipc.c
+++ b/drivers/soc/ti/wkup_m3_ipc.c
@@ -630,10 +630,8 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev)
 
 	ret = devm_request_irq(dev, irq, wkup_m3_txev_handler,
 			       0, "wkup_m3_txev", m3_ipc);
-	if (ret) {
-		dev_err(dev, "request_irq failed\n");
+	if (ret)
 		return ret;
-	}
 
 	m3_ipc->mbox_client.dev = dev;
 	m3_ipc->mbox_client.tx_done = NULL;
-- 
2.34.1

Re: [PATCH v2] soc: ti: wkup_m3_ipc: Remove redundant dev_err()

Posted by Nishanth Menon 2 days, 10 hours ago

On 10:35-20260722, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
> 
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> Reviewed-by: Hari Prasath Gujulan Elango <gehariprasath@ti.com>
> ---

Did anything change in V2? we don't need to post a v2 purely to pick up
reviewed-by. B4 will handle it.

>  drivers/soc/ti/wkup_m3_ipc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 5845fc652adc..f8640cdc2a21 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -630,10 +630,8 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev)
>  
>  	ret = devm_request_irq(dev, irq, wkup_m3_txev_handler,
>  			       0, "wkup_m3_txev", m3_ipc);
> -	if (ret) {
> -		dev_err(dev, "request_irq failed\n");
> +	if (ret)
>  		return ret;
> -	}
>  
>  	m3_ipc->mbox_client.dev = dev;
>  	m3_ipc->mbox_client.tx_done = NULL;
> -- 
> 2.34.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource

Re: [PATCH v2] soc: ti: wkup_m3_ipc: Remove redundant dev_err()

Posted by Pan Chuang 1 day, 20 hours ago

On 2026/7/22 21:10, Nishanth Menon wrote:
> On 10:35-20260722, Pan Chuang wrote:
>> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
>> devm_request_*_irq()"), devm_request_irq() automatically logs
>> detailed error messages on failure. Remove the now-redundant
>> driver-specific dev_err() calls.
>>
>> Signed-off-by: Pan Chuang <panchuang@vivo.com>
>> Reviewed-by: Hari Prasath Gujulan Elango <gehariprasath@ti.com>
>> ---
>
> Did anything change in V2? we don't need to post a v2 purely to pick up
> reviewed-by. B4 will handle it.
>
Sorry – please ignore this. I'll resend a new version without the v2 tag. 


Best Regards,

PanChuang