Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"),
devm_request_irq() and devm_request_threaded_irq() automatically log
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
drivers/soc/qcom/qcom_aoss.c | 4 +---
drivers/soc/qcom/smp2p.c | 4 +---
drivers/soc/qcom/smsm.c | 4 +---
3 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
index 259c41f0c34e..a6b673cd7678 100644
--- a/drivers/soc/qcom/qcom_aoss.c
+++ b/drivers/soc/qcom/qcom_aoss.c
@@ -602,10 +602,8 @@ static int qmp_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
ret = devm_request_irq(&pdev->dev, irq, qmp_intr, 0,
"aoss-qmp", qmp);
- if (ret < 0) {
- dev_err(&pdev->dev, "failed to request interrupt\n");
+ if (ret < 0)
goto err_free_mbox;
- }
ret = qmp_open(qmp);
if (ret < 0)
diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c
index af0ceeaf6e07..6f07fef40ce8 100644
--- a/drivers/soc/qcom/smp2p.c
+++ b/drivers/soc/qcom/smp2p.c
@@ -720,10 +720,8 @@ static int qcom_smp2p_probe(struct platform_device *pdev)
NULL, qcom_smp2p_intr,
IRQF_ONESHOT,
NULL, (void *)smp2p);
- if (ret) {
- dev_err(&pdev->dev, "failed to request interrupt\n");
+ if (ret)
goto unwind_interfaces;
- }
/*
* Treat smp2p interrupt as wakeup source, but keep it disabled
diff --git a/drivers/soc/qcom/smsm.c b/drivers/soc/qcom/smsm.c
index 021e9d1f61dc..396025074e1e 100644
--- a/drivers/soc/qcom/smsm.c
+++ b/drivers/soc/qcom/smsm.c
@@ -451,10 +451,8 @@ static int smsm_inbound_entry(struct qcom_smsm *smsm,
NULL, smsm_intr,
IRQF_ONESHOT,
"smsm", (void *)entry);
- if (ret) {
- dev_err(smsm->dev, "failed to request interrupt\n");
+ if (ret)
return ret;
- }
entry->domain = irq_domain_create_linear(of_fwnode_handle(node), 32, &smsm_irq_ops, entry);
if (!entry->domain) {
--
2.34.1