drivers/soc/fsl/dpio/dpio-driver.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/soc/fsl/dpio/dpio-driver.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/soc/fsl/dpio/dpio-driver.c b/drivers/soc/fsl/dpio/dpio-driver.c
index 9e3fddd8f5a9..d5198ffc4455 100644
--- a/drivers/soc/fsl/dpio/dpio-driver.c
+++ b/drivers/soc/fsl/dpio/dpio-driver.c
@@ -102,12 +102,8 @@ static int register_dpio_irq_handlers(struct fsl_mc_device *dpio_dev, int cpu)
0,
dev_name(&dpio_dev->dev),
&dpio_dev->dev);
- if (error < 0) {
- dev_err(&dpio_dev->dev,
- "devm_request_irq() failed: %d\n",
- error);
+ if (error < 0)
return error;
- }
/* set the affinity hint */
if (irq_set_affinity_hint(irq->virq, cpumask_of(cpu)))
--
2.34.1Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/soc/ixp4xx/ixp4xx-qmgr.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/soc/ixp4xx/ixp4xx-qmgr.c b/drivers/soc/ixp4xx/ixp4xx-qmgr.c
index 475e229039e3..6e1fca630b80 100644
--- a/drivers/soc/ixp4xx/ixp4xx-qmgr.c
+++ b/drivers/soc/ixp4xx/ixp4xx-qmgr.c
@@ -421,19 +421,13 @@ static int ixp4xx_qmgr_probe(struct platform_device *pdev)
err = devm_request_irq(dev, irq1, handler1, 0, "IXP4xx Queue Manager",
NULL);
- if (err) {
- dev_err(dev, "failed to request IRQ%i (%i)\n",
- irq1, err);
+ if (err)
return err;
- }
err = devm_request_irq(dev, irq2, handler2, 0, "IXP4xx Queue Manager",
NULL);
- if (err) {
- dev_err(dev, "failed to request IRQ%i (%i)\n",
- irq2, err);
+ if (err)
return err;
- }
used_sram_bitmap[0] = 0xF; /* 4 first pages reserved for config */
spin_lock_init(&qmgr_lock);
--
2.34.1On Wed, Jul 22, 2026 at 4:35 AM Pan Chuang <panchuang@vivo.com> wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
Patch applied.
Yours,
Linus Walleij
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
Reviewed-by: Hari Prasath Gujulan Elango <gehariprasath@ti.com>
---
drivers/soc/ti/wkup_m3_ipc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
index 5845fc652adc..f8640cdc2a21 100644
--- a/drivers/soc/ti/wkup_m3_ipc.c
+++ b/drivers/soc/ti/wkup_m3_ipc.c
@@ -630,10 +630,8 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev)
ret = devm_request_irq(dev, irq, wkup_m3_txev_handler,
0, "wkup_m3_txev", m3_ipc);
- if (ret) {
- dev_err(dev, "request_irq failed\n");
+ if (ret)
return ret;
- }
m3_ipc->mbox_client.dev = dev;
m3_ipc->mbox_client.tx_done = NULL;
--
2.34.1On 10:35-20260722, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> Reviewed-by: Hari Prasath Gujulan Elango <gehariprasath@ti.com>
> ---
Did anything change in V2? we don't need to post a v2 purely to pick up
reviewed-by. B4 will handle it.
> drivers/soc/ti/wkup_m3_ipc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 5845fc652adc..f8640cdc2a21 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -630,10 +630,8 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev)
>
> ret = devm_request_irq(dev, irq, wkup_m3_txev_handler,
> 0, "wkup_m3_txev", m3_ipc);
> - if (ret) {
> - dev_err(dev, "request_irq failed\n");
> + if (ret)
> return ret;
> - }
>
> m3_ipc->mbox_client.dev = dev;
> m3_ipc->mbox_client.tx_done = NULL;
> --
> 2.34.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
https://ti.com/opensource
On 2026/7/22 21:10, Nishanth Menon wrote:
> On 10:35-20260722, Pan Chuang wrote:
>> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
>> devm_request_*_irq()"), devm_request_irq() automatically logs
>> detailed error messages on failure. Remove the now-redundant
>> driver-specific dev_err() calls.
>>
>> Signed-off-by: Pan Chuang <panchuang@vivo.com>
>> Reviewed-by: Hari Prasath Gujulan Elango <gehariprasath@ti.com>
>> ---
>
> Did anything change in V2? we don't need to post a v2 purely to pick up
> reviewed-by. B4 will handle it.
>
Sorry – please ignore this. I'll resend a new version without the v2 tag.
Best Regards,
PanChuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Acked-by: Michal Simek <michal.simek@amd.com>
---
drivers/soc/xilinx/zynqmp_power.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c
index 370e61ac47d8..54c796afb89e 100644
--- a/drivers/soc/xilinx/zynqmp_power.c
+++ b/drivers/soc/xilinx/zynqmp_power.c
@@ -368,11 +368,8 @@ static int zynqmp_pm_probe(struct platform_device *pdev)
IRQF_NO_SUSPEND | IRQF_ONESHOT,
dev_name(&pdev->dev),
&pdev->dev);
- if (ret) {
- dev_err(&pdev->dev, "devm_request_threaded_irq '%d' failed with %d\n",
- irq, ret);
+ if (ret)
return ret;
- }
} else {
dev_err(&pdev->dev, "Required property not found in DT node\n");
return -ENOENT;
--
2.34.1
On 7/22/26 04:35, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> Acked-by: Michal Simek <michal.simek@amd.com>
> ---
> drivers/soc/xilinx/zynqmp_power.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c
> index 370e61ac47d8..54c796afb89e 100644
> --- a/drivers/soc/xilinx/zynqmp_power.c
> +++ b/drivers/soc/xilinx/zynqmp_power.c
> @@ -368,11 +368,8 @@ static int zynqmp_pm_probe(struct platform_device *pdev)
> IRQF_NO_SUSPEND | IRQF_ONESHOT,
> dev_name(&pdev->dev),
> &pdev->dev);
> - if (ret) {
> - dev_err(&pdev->dev, "devm_request_threaded_irq '%d' failed with %d\n",
> - irq, ret);
> + if (ret)
> return ret;
> - }
> } else {
> dev_err(&pdev->dev, "Required property not found in DT node\n");
> return -ENOENT;
But you still send it as threaded not really separate emails.
When you pass this message-id I am getting ti patch not xilinx one.
Thanks,
Michal
b4 am -l 20260722023523.42269-7-panchuang@vivo.com
Looking up 20260722023523.42269-7-panchuang@vivo.com
Analyzing 8 messages in the thread
WARNING: duplicate messages found at index 1
Subject 1: soc/tegra: cbb: Remove redundant dev_err()
Subject 2: soc: xilinx: Remove redundant dev_err()
2 is not a reply... assume additional patch
WARNING: duplicate messages found at index 1
Subject 1: soc: qcom: Remove redundant dev_err()
Subject 2: soc/tegra: cbb: Remove redundant dev_err()
2 is not a reply... assume additional patch
WARNING: duplicate messages found at index 1
Subject 1: soc: fsl: dpio: Remove redundant dev_err()
Subject 2: soc: qcom: Remove redundant dev_err()
2 is not a reply... assume additional patch
Assuming new revision: v2 ([PATCH v2] soc: ixp4xx: Remove redundant dev_err())
Assuming new revision: v2 ([PATCH v2] soc: mediatek: mtk-svs: Remove redundant
dev_err_probe())
Assuming new revision: v2 ([PATCH v2] soc: ti: wkup_m3_ipc: Remove redundant
dev_err())
Looking for additional code-review trailers on lore.kernel.org
Analyzing 13 code-review messages
Checking attestation on all messages, may take a moment...
---
✓ [PATCH v2] soc: ti: wkup_m3_ipc: Remove redundant dev_err()
+ Link: https://patch.msgid.link/20260722023523.42269-6-panchuang@vivo.com
---
✓ Signed: DKIM/vivo.com
---
Total patches: 1
---
Link: https://patch.msgid.link/20260722023523.42269-6-panchuang@vivo.com
git am
./v2_20260722_panchuang_soc_ti_wkup_m3_ipc_remove_redundant_dev_err.mbx
On 2026/7/22 21:14, Michal Simek wrote:
>
>
> On 7/22/26 04:35, Pan Chuang wrote:
>> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
>> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
>> detailed error messages on failure. Remove the now-redundant
>> driver-specific dev_err() calls.
>>
>> Signed-off-by: Pan Chuang <panchuang@vivo.com>
>> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
>> Acked-by: Michal Simek <michal.simek@amd.com>
>> ---
>> drivers/soc/xilinx/zynqmp_power.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c
>> index 370e61ac47d8..54c796afb89e 100644
>> --- a/drivers/soc/xilinx/zynqmp_power.c
>> +++ b/drivers/soc/xilinx/zynqmp_power.c
>> @@ -368,11 +368,8 @@ static int zynqmp_pm_probe(struct platform_device *pdev)
>> IRQF_NO_SUSPEND | IRQF_ONESHOT,
>> dev_name(&pdev->dev),
>> &pdev->dev);
>> - if (ret) {
>> - dev_err(&pdev->dev, "devm_request_threaded_irq '%d' failed with %d\n",
>> - irq, ret);
>> + if (ret)
>> return ret;
>> - }
>> } else {
>> dev_err(&pdev->dev, "Required property not found in DT node\n");
>> return -ENOENT;
>
> But you still send it as threaded not really separate emails.
>
> When you pass this message-id I am getting ti patch not xilinx one.
>
> Thanks,
> Michal
>
> b4 am -l 20260722023523.42269-7-panchuang@vivo.com
> Looking up 20260722023523.42269-7-panchuang@vivo.com
> Analyzing 8 messages in the thread
> WARNING: duplicate messages found at index 1
> Subject 1: soc/tegra: cbb: Remove redundant dev_err()
> Subject 2: soc: xilinx: Remove redundant dev_err()
> 2 is not a reply... assume additional patch
> WARNING: duplicate messages found at index 1
> Subject 1: soc: qcom: Remove redundant dev_err()
> Subject 2: soc/tegra: cbb: Remove redundant dev_err()
> 2 is not a reply... assume additional patch
> WARNING: duplicate messages found at index 1
> Subject 1: soc: fsl: dpio: Remove redundant dev_err()
> Subject 2: soc: qcom: Remove redundant dev_err()
> 2 is not a reply... assume additional patch
> Assuming new revision: v2 ([PATCH v2] soc: ixp4xx: Remove redundant dev_err())
> Assuming new revision: v2 ([PATCH v2] soc: mediatek: mtk-svs: Remove redundant dev_err_probe())
> Assuming new revision: v2 ([PATCH v2] soc: ti: wkup_m3_ipc: Remove redundant dev_err())
> Looking for additional code-review trailers on lore.kernel.org
> Analyzing 13 code-review messages
> Checking attestation on all messages, may take a moment...
> ---
> ✓ [PATCH v2] soc: ti: wkup_m3_ipc: Remove redundant dev_err()
> + Link: https://patch.msgid.link/20260722023523.42269-6-panchuang@vivo.com
> ---
> ✓ Signed: DKIM/vivo.com
> ---
> Total patches: 1
> ---
> Link: https://patch.msgid.link/20260722023523.42269-6-panchuang@vivo.com
> git am ./v2_20260722_panchuang_soc_ti_wkup_m3_ipc_remove_redundant_dev_err.mbx
>
Sorry for the confusion. I'll resend each platform patch as a standalone email.
Best Regards,
PanChuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/soc/mediatek/mtk-svs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index 99edecb204f2..39af0728ce61 100644
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -2908,10 +2908,8 @@ static int svs_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(svsp->dev, svsp_irq, NULL, svs_isr,
IRQF_ONESHOT, svsp_data->name, svsp);
- if (ret) {
- dev_err_probe(svsp->dev, ret, "register irq(%d) failed\n", svsp_irq);
+ if (ret)
goto svs_probe_iounmap;
- }
ret = svs_start(svsp);
if (ret) {
--
2.34.1Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"),
devm_request_irq() and devm_request_threaded_irq() automatically log
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
drivers/soc/qcom/qcom_aoss.c | 4 +---
drivers/soc/qcom/smp2p.c | 4 +---
drivers/soc/qcom/smsm.c | 4 +---
3 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
index 259c41f0c34e..a6b673cd7678 100644
--- a/drivers/soc/qcom/qcom_aoss.c
+++ b/drivers/soc/qcom/qcom_aoss.c
@@ -602,10 +602,8 @@ static int qmp_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
ret = devm_request_irq(&pdev->dev, irq, qmp_intr, 0,
"aoss-qmp", qmp);
- if (ret < 0) {
- dev_err(&pdev->dev, "failed to request interrupt\n");
+ if (ret < 0)
goto err_free_mbox;
- }
ret = qmp_open(qmp);
if (ret < 0)
diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c
index af0ceeaf6e07..6f07fef40ce8 100644
--- a/drivers/soc/qcom/smp2p.c
+++ b/drivers/soc/qcom/smp2p.c
@@ -720,10 +720,8 @@ static int qcom_smp2p_probe(struct platform_device *pdev)
NULL, qcom_smp2p_intr,
IRQF_ONESHOT,
NULL, (void *)smp2p);
- if (ret) {
- dev_err(&pdev->dev, "failed to request interrupt\n");
+ if (ret)
goto unwind_interfaces;
- }
/*
* Treat smp2p interrupt as wakeup source, but keep it disabled
diff --git a/drivers/soc/qcom/smsm.c b/drivers/soc/qcom/smsm.c
index 021e9d1f61dc..396025074e1e 100644
--- a/drivers/soc/qcom/smsm.c
+++ b/drivers/soc/qcom/smsm.c
@@ -451,10 +451,8 @@ static int smsm_inbound_entry(struct qcom_smsm *smsm,
NULL, smsm_intr,
IRQF_ONESHOT,
"smsm", (void *)entry);
- if (ret) {
- dev_err(smsm->dev, "failed to request interrupt\n");
+ if (ret)
return ret;
- }
entry->domain = irq_domain_create_linear(of_fwnode_handle(node), 32, &smsm_irq_ops, entry);
if (!entry->domain) {
--
2.34.1Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/soc/tegra/cbb/tegra194-cbb.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/soc/tegra/cbb/tegra194-cbb.c b/drivers/soc/tegra/cbb/tegra194-cbb.c
index 2f69e104c838..69ef929e04f8 100644
--- a/drivers/soc/tegra/cbb/tegra194-cbb.c
+++ b/drivers/soc/tegra/cbb/tegra194-cbb.c
@@ -2072,20 +2072,15 @@ static int tegra194_cbb_interrupt_enable(struct tegra_cbb *cbb)
if (priv->sec_irq) {
err = devm_request_irq(dev, priv->sec_irq, tegra194_cbb_err_isr, 0, dev_name(dev),
priv);
- if (err) {
- dev_err(dev, "failed to register interrupt %u: %d\n", priv->sec_irq, err);
+ if (err)
return err;
- }
}
if (priv->nonsec_irq) {
err = devm_request_irq(dev, priv->nonsec_irq, tegra194_cbb_err_isr, 0,
dev_name(dev), priv);
- if (err) {
- dev_err(dev, "failed to register interrupt %u: %d\n", priv->nonsec_irq,
- err);
+ if (err)
return err;
- }
}
return 0;
--
2.34.1© 2016 - 2026 Red Hat, Inc.