This series removes functions in pci/hmm/ that are declared and defined
but never called.

Nikolay Kulikov (2):
  staging: media: atomisp: remove unused functions from hmm.c
  staging: media: atomisp: remove unused functions from hmm_bo.c

 .../staging/media/atomisp/include/hmm/hmm.h   | 16 ---
 .../media/atomisp/include/hmm/hmm_bo.h        | 19 ----
 drivers/staging/media/atomisp/pci/hmm/hmm.c   | 41 --------
 .../staging/media/atomisp/pci/hmm/hmm_bo.c    | 97 -------------------
 4 files changed, 173 deletions(-)


base-commit: cb08dcd0a896c3ac8073a57296f2377b106c35b4
-- 
2.55.0

On Wed, Jul 22, 2026 at 12:42 AM Nikolay Kulikov <nikolayof23@gmail.com> wrote:
>
> This series removes functions in pci/hmm/ that are declared and defined
> but never called.

Don't do it per file, squash these changes as it seems not so many of
them (I assume you checked the entire driver, right?).

-- 
With Best Regards,
Andy Shevchenko

On Wed, Jul 22, 2026 at 7:58 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Wed, Jul 22, 2026 at 12:42 AM Nikolay Kulikov <nikolayof23@gmail.com> wrote:
> >
> > This series removes functions in pci/hmm/ that are declared and defined
> > but never called.
>
> Don't do it per file, squash these changes as it seems not so many of
> them (I assume you checked the entire driver, right?).

Note, if you want to make a useful contribution, try to clean up the
below header

include / hmm / hmm_common.h

It has some ugly macros, instead this code should go to the users and
then be propagated to each level and refactored.

-- 
With Best Regards,
Andy Shevchenko

On Wed, Jul 22, 2026 at 08:08:38AM +0300, Andy Shevchenko wrote:
> On Wed, Jul 22, 2026 at 7:58 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Wed, Jul 22, 2026 at 12:42 AM Nikolay Kulikov <nikolayof23@gmail.com> wrote:
> > >
> > > This series removes functions in pci/hmm/ that are declared and defined
> > > but never called.
> >
> > Don't do it per file, squash these changes as it seems not so many of
> > them (I assume you checked the entire driver, right?).

Yes, the entire driver. I usually use 'git grep' from its root.

> 
> Note, if you want to make a useful contribution, try to clean up the
> below header
> 
> include / hmm / hmm_common.h
> 
> It has some ugly macros, instead this code should go to the users and
> then be propagated to each level and refactored.

I'll add this to v2.


Thanks,
Nikolay

> 
> -- 
> With Best Regards,
> Andy Shevchenko