dmaengine: fsl_raid: fix resource leaks and simplify drvdata handling

[PATCHv2 0/2] dmaengine: fsl_raid: fix resource leaks and simplify drvdata handling

Rosen Penev posted 2 patches 3 days, 3 hours ago

Download series mbox

drivers/dma/fsl_raid.c | 33 ++++++++++++++++++++-------------
drivers/dma/fsl_raid.h |  1 +
2 files changed, 21 insertions(+), 13 deletions(-)

Expand all Fold all

[PATCHv2 0/2] dmaengine: fsl_raid: fix resource leaks and simplify drvdata handling

Posted by Rosen Penev 3 days, 3 hours ago

This series fixes resource leaks in the FSL RAIDEngine driver and
simplifies drvdata handling:

1) Replace dev_get_drvdata/dev_set_drvdata with platform_get_drvdata/
   platform_set_drvdata, since a platform_device is always used. This
   avoids taking a pointer to a platform device member.

2) Add missing free_irq() in error unwind of fsl_re_chan_probe() and in
   fsl_re_remove_chan(). Also add tasklet_kill() and
   of_platform_device_destroy() to properly release all resources.

v2: split into two patches

Rosen Penev (2):
  dmaengine: fsl_raid: pass platform_device to drvdata
  dmaengine: fsl_raid: free resources in probe

 drivers/dma/fsl_raid.c | 33 ++++++++++++++++++++-------------
 drivers/dma/fsl_raid.h |  1 +
 2 files changed, 21 insertions(+), 13 deletions(-)

-- 
2.55.0