[PATCH v4 0/2] staging: media: atomisp: Cleanup unused module parameters

Prajval Chaudhary posted 2 patches 3 days, 6 hours ago
.../staging/media/atomisp/pci/atomisp_common.h    |  6 ++----
.../media/atomisp/pci/atomisp_compat_css20.c      | 12 +++---------
drivers/staging/media/atomisp/pci/atomisp_v4l2.c  | 15 ++-------------
.../pci/runtime/debug/interface/ia_css_debug.h    |  7 +++----
.../atomisp/pci/runtime/debug/src/ia_css_debug.c  |  4 ++--
5 files changed, 12 insertions(+), 32 deletions(-)
[PATCH v4 0/2] staging: media: atomisp: Cleanup unused module parameters
Posted by Prajval Chaudhary 3 days, 6 hours ago
This series cleans up unused module parameters from the atomisp driver.

Patch 1 removes unused 'pad_w' and 'pad_h' module parameters.
Patch 2 removes unused 'dbg_level' and 'dbg_func' module parameters, 
and updates ia_css_debug_vdtrace() to filter trace logging to WARNING 
level or below to avoid potential kernel log flooding.

Changes in v4:
 - Fix macro constant name in ia_css_debug_vdtrace()
   to IA_CSS_DEBUG_WARNING.
 - Guard vprintk() with level check to prevent log flooding.

Changes in v3:
 - [Add brief note if applicable]

Changes in v2:
 - [Add brief note if applicable]

Prajval Chaudhary (2):
  staging: media: atomisp: Remove pad_w and pad_h module parameters
  staging: media: atomisp: Remove dbg_level and dbg_func module
    parameters

 .../staging/media/atomisp/pci/atomisp_common.h    |  6 ++----
 .../media/atomisp/pci/atomisp_compat_css20.c      | 12 +++---------
 drivers/staging/media/atomisp/pci/atomisp_v4l2.c  | 15 ++-------------
 .../pci/runtime/debug/interface/ia_css_debug.h    |  7 +++----
 .../atomisp/pci/runtime/debug/src/ia_css_debug.c  |  4 ++--
 5 files changed, 12 insertions(+), 32 deletions(-)

-- 
2.34.1
Re: [PATCH v4 0/2] staging: media: atomisp: Cleanup unused module parameters
Posted by Andy Shevchenko 3 days, 2 hours ago
On Tue, Jul 21, 2026 at 10:05:30PM +0530, Prajval Chaudhary wrote:
> This series cleans up unused module parameters from the atomisp driver.
> 
> Patch 1 removes unused 'pad_w' and 'pad_h' module parameters.
> Patch 2 removes unused 'dbg_level' and 'dbg_func' module parameters, 
> and updates ia_css_debug_vdtrace() to filter trace logging to WARNING 
> level or below to avoid potential kernel log flooding.

Have you run (or simulate behaviour of) this driver? Can you show the difference
in the debug output before and after these patches?

-- 
With Best Regards,
Andy Shevchenko