[PATCH] serial: 8250: remove always included kconfig.h

Hugo Villeneuve posted 1 patch 3 days, 9 hours ago
drivers/tty/serial/8250/8250.h | 1 -
1 file changed, 1 deletion(-)
[PATCH] serial: 8250: remove always included kconfig.h
Posted by Hugo Villeneuve 3 days, 9 hours ago
From: Hugo Villeneuve <hvilleneuve@dimonoff.com>

The inclusion of <linux/kconfig.h> in commit 7ab80d1e72431 ("serial: 8250:
fix compile error with hub6_match_port() when compiled as a module") is
unneeded as it's guaranteed by the build starting from commit 2a11c8ea20bf
("kconfig: Introduce IS_ENABLED(), IS_BUILTIN() and IS_MODULE()").
Remove it here.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
---
Maybe this could be merged with commit 7ab80d1e72431 ("serial: 8250: fix
compile error with hub6_match_port() when compiled as a module") since it
is, for now, only in tty-testing?
---
 drivers/tty/serial/8250/8250.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h
index b62f88eec881f..f72c7e7bb94f6 100644
--- a/drivers/tty/serial/8250/8250.h
+++ b/drivers/tty/serial/8250/8250.h
@@ -8,7 +8,6 @@
  */
 
 #include <linux/bits.h>
-#include <linux/kconfig.h>
 #include <linux/serial_8250.h>
 #include <linux/serial_core.h>
 #include <linux/dmaengine.h>

base-commit: 782f4dbd1794b4f30dc116a7ca42c5962c409be8
-- 
2.47.3
Re: [PATCH] serial: 8250: remove always included kconfig.h
Posted by Andy Shevchenko 3 days, 3 hours ago
On Tue, Jul 21, 2026 at 10:48:32AM -0400, Hugo Villeneuve wrote:

> The inclusion of <linux/kconfig.h> in commit 7ab80d1e72431 ("serial: 8250:
> fix compile error with hub6_match_port() when compiled as a module") is
> unneeded as it's guaranteed by the build starting from commit 2a11c8ea20bf
> ("kconfig: Introduce IS_ENABLED(), IS_BUILTIN() and IS_MODULE()").
> Remove it here.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko