include/linux/property.h | 2 ++ 1 file changed, 2 insertions(+)
Mark the @value union members as private since they are an internal
representation of @value. This prevents kernel-doc warnings:
Warning: include/linux/property.h:406 struct member 'u8_data' not
described in 'property_entry'
Warning: include/linux/property.h:406 struct member 'u16_data' not
described in 'property_entry'
Warning: include/linux/property.h:406 struct member 'u32_data' not
described in 'property_entry'
Warning: include/linux/property.h:406 struct member 'u64_data' not
described in 'property_entry'
Warning: include/linux/property.h:406 struct member 'str' not described
in 'property_entry'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
v2: use private: for the internal representation of @value (Andy S.).
drop Sakari's Ack since the patch changed.
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Daniel Scally <djrscally@gmail.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-acpi@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: driver-core@lists.linux.dev
include/linux/property.h | 2 ++
1 file changed, 2 insertions(+)
--- linux-next-20260720.orig/include/linux/property.h
+++ linux-next-20260720/include/linux/property.h
@@ -397,11 +397,13 @@ struct property_entry {
union {
const void *pointer;
union {
+ /* private: internal representation of @value */
u8 u8_data[sizeof(u64) / sizeof(u8)];
u16 u16_data[sizeof(u64) / sizeof(u16)];
u32 u32_data[sizeof(u64) / sizeof(u32)];
u64 u64_data[sizeof(u64) / sizeof(u64)];
const char *str[sizeof(u64) / sizeof(char *)];
+ /* public: */
} value;
};
};
On Mon, 20 Jul 2026 19:32:18 -0700, Randy Dunlap wrote:
> [PATCH v2] device property: mark internal data as private for kernel-doc
Applied, thanks!
Branch: driver-core-testing
Tree: git://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git
[1/1] device property: mark internal data as private for kernel-doc
commit: 503735347320
The patch will appear in the next linux-next integration (typically within 24
hours on weekdays).
The patch is in the driver-core-testing branch and will be promoted to
driver-core-next after validation.
On Mon, Jul 20, 2026 at 07:32:18PM -0700, Randy Dunlap wrote: > Mark the @value union members as private since they are an internal > representation of @value. This prevents kernel-doc warnings: > > Warning: include/linux/property.h:406 struct member 'u8_data' not > described in 'property_entry' > Warning: include/linux/property.h:406 struct member 'u16_data' not > described in 'property_entry' > Warning: include/linux/property.h:406 struct member 'u32_data' not > described in 'property_entry' > Warning: include/linux/property.h:406 struct member 'u64_data' not > described in 'property_entry' > Warning: include/linux/property.h:406 struct member 'str' not described > in 'property_entry' Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> -- With Best Regards, Andy Shevchenko
© 2016 - 2026 Red Hat, Inc.