[PATCH v2 0/3] drm/nouveau: Fix WARN_ON() from missing blend modes

Lyude Paul posted 3 patches 4 days, 4 hours ago
There is a newer version of this series
drivers/gpu/drm/nouveau/dispnv50/curs507a.c |  3 ++
drivers/gpu/drm/nouveau/dispnv50/disp.c     |  4 +++
drivers/gpu/drm/nouveau/dispnv50/wndw.c     | 40 +++++++++++++++++----
drivers/gpu/drm/nouveau/dispnv50/wndw.h     | 11 ++++++
drivers/gpu/drm/nouveau/dispnv50/wndwc37e.c |  1 +
drivers/gpu/drm/nouveau/dispnv50/wndwc57e.c |  1 +
drivers/gpu/drm/nouveau/dispnv50/wndwc67e.c |  1 +
drivers/gpu/drm/nouveau/dispnv50/wndwca7e.c |  1 +
8 files changed, 55 insertions(+), 7 deletions(-)
[PATCH v2 0/3] drm/nouveau: Fix WARN_ON() from missing blend modes
Posted by Lyude Paul 4 days, 4 hours ago
Recently a change went into the kernel to ensure that drivers which
expose color formats which have alpha channels. This would cause nouveau
to hit a WARN_ON when setting up cursors, since they do support blending
- but we never bothered trying to hook up the controls for it to
nouveau.

This fixes the issue by ensuring that nouveau always exposes a blend
mode for any planes with alpha channels, regardless of whether or not we
have control of the blend mode hooked up. If someone wants to add
control for this in the future as well, it should be fairly easy to hook
up with this.

Previous version:
	https://patchwork.freedesktop.org/patch/741031/

Lyude Paul (3):
  drm/nouveau/kms/nv50-: Add .blend_modes to nv50_wndw_func
  drm/nouveau/kms/nv50-: Introduce nv50_wndw_default_state()
  drm/nouveau/kms/nv50-: Unconditionally create blend_mode prop for
    wndws

 drivers/gpu/drm/nouveau/dispnv50/curs507a.c |  3 ++
 drivers/gpu/drm/nouveau/dispnv50/disp.c     |  4 +++
 drivers/gpu/drm/nouveau/dispnv50/wndw.c     | 40 +++++++++++++++++----
 drivers/gpu/drm/nouveau/dispnv50/wndw.h     | 11 ++++++
 drivers/gpu/drm/nouveau/dispnv50/wndwc37e.c |  1 +
 drivers/gpu/drm/nouveau/dispnv50/wndwc57e.c |  1 +
 drivers/gpu/drm/nouveau/dispnv50/wndwc67e.c |  1 +
 drivers/gpu/drm/nouveau/dispnv50/wndwca7e.c |  1 +
 8 files changed, 55 insertions(+), 7 deletions(-)


base-commit: b0a652436b892eb9a036a031b33099dca036faaa
-- 
2.55.0
Re: [PATCH v2 0/3] drm/nouveau: Fix WARN_ON() from missing blend modes
Posted by lyude@redhat.com 3 days, 5 hours ago
I had thought that testing this on fbcon would be enough, but there is
still more issues with this series I found when adding these to the
kernel I dog food on my desktop. Will figure them out and send another
respin of this series asap

On Mon, 2026-07-20 at 16:43 -0400, Lyude Paul wrote:
> Recently a change went into the kernel to ensure that drivers which
> expose color formats which have alpha channels. This would cause
> nouveau
> to hit a WARN_ON when setting up cursors, since they do support
> blending
> - but we never bothered trying to hook up the controls for it to
> nouveau.
> 
> This fixes the issue by ensuring that nouveau always exposes a blend
> mode for any planes with alpha channels, regardless of whether or not
> we
> have control of the blend mode hooked up. If someone wants to add
> control for this in the future as well, it should be fairly easy to
> hook
> up with this.
> 
> Previous version:
> 	https://patchwork.freedesktop.org/patch/741031/
> 
> Lyude Paul (3):
>   drm/nouveau/kms/nv50-: Add .blend_modes to nv50_wndw_func
>   drm/nouveau/kms/nv50-: Introduce nv50_wndw_default_state()
>   drm/nouveau/kms/nv50-: Unconditionally create blend_mode prop for
>     wndws
> 
>  drivers/gpu/drm/nouveau/dispnv50/curs507a.c |  3 ++
>  drivers/gpu/drm/nouveau/dispnv50/disp.c     |  4 +++
>  drivers/gpu/drm/nouveau/dispnv50/wndw.c     | 40 +++++++++++++++++--
> --
>  drivers/gpu/drm/nouveau/dispnv50/wndw.h     | 11 ++++++
>  drivers/gpu/drm/nouveau/dispnv50/wndwc37e.c |  1 +
>  drivers/gpu/drm/nouveau/dispnv50/wndwc57e.c |  1 +
>  drivers/gpu/drm/nouveau/dispnv50/wndwc67e.c |  1 +
>  drivers/gpu/drm/nouveau/dispnv50/wndwca7e.c |  1 +
>  8 files changed, 55 insertions(+), 7 deletions(-)
> 
> 
> base-commit: b0a652436b892eb9a036a031b33099dca036faaa