s390/maccess: use proper PTE accessors for copying old memory

[PATCH] s390/maccess: use proper PTE accessors for copying old memory

Posted by Alexander Gordeev 4 days, 10 hours ago

Follow the pattern established by commit c33c794828f2 ("mm:
ptep_get() conversion") and use proper PTE accessors instead
of a direct pointer dereference in memcpy_real_iter().

Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
---
 arch/s390/mm/maccess.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/mm/maccess.c b/arch/s390/mm/maccess.c
index cfd219fe495c..f39968dd8063 100644
--- a/arch/s390/mm/maccess.c
+++ b/arch/s390/mm/maccess.c
@@ -96,7 +96,7 @@ size_t memcpy_real_iter(struct iov_iter *iter, unsigned long src, size_t count)
 		pte = mk_pte_phys(phys, PAGE_KERNEL_RO);
 
 		mutex_lock(&memcpy_real_mutex);
-		if (pte_val(pte) != pte_val(*memcpy_real_ptep)) {
+		if (pte_val(pte) != pte_val(ptep_get(memcpy_real_ptep))) {
 			__ptep_ipte(__memcpy_real_area, memcpy_real_ptep, 0, 0, IPTE_GLOBAL);
 			set_pte(memcpy_real_ptep, pte);
 		}
-- 
2.53.0

Re: [PATCH] s390/maccess: use proper PTE accessors for copying old memory

Posted by Vasily Gorbik 3 days, 15 hours ago

On Mon, Jul 20, 2026 at 04:47:34PM +0200, Alexander Gordeev wrote:
> Follow the pattern established by commit c33c794828f2 ("mm:
> ptep_get() conversion") and use proper PTE accessors instead
> of a direct pointer dereference in memcpy_real_iter().
> 
> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
> ---
>  arch/s390/mm/maccess.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thank you!

Re: [PATCH] s390/maccess: use proper PTE accessors for copying old memory

Posted by Heiko Carstens 3 days, 16 hours ago

On Mon, Jul 20, 2026 at 04:47:34PM +0200, Alexander Gordeev wrote:
> Follow the pattern established by commit c33c794828f2 ("mm:
> ptep_get() conversion") and use proper PTE accessors instead
> of a direct pointer dereference in memcpy_real_iter().
> 
> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
> ---
>  arch/s390/mm/maccess.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch subject needs to be fixed. Upper case "Use".
Besides that:

Reviewed-by: Heiko Carstens <hca@linux.ibm.com>