staging: sm750fb: rename pvReg to avoid CamelCase

[PATCH] staging: sm750fb: rename pvReg to avoid CamelCase

Posted by Olivier Tanoh 4 days, 18 hours ago

Fix checkpatch.pl warning regarding the use of CamelCase:
CHECK: Avoid CamelCase: <pvReg>

Rename the struct member pvReg to reg across the driver to
comply with the Linux kernel coding style.

Signed-off-by: Olivier Tanoh <olivier.tanoh19@gmail.com>
---
 drivers/staging/sm750fb/sm750.c    |  4 ++--
 drivers/staging/sm750fb/sm750.h    |  2 +-
 drivers/staging/sm750fb/sm750_hw.c | 12 ++++++------
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 89c811e0806c..c5f43a364437 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -743,7 +743,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
 	 * must be set after crtc member initialized
 	 */
 	crtc->cursor.offset = crtc->o_screen + crtc->vidmem_size - 1024;
-	crtc->cursor.mmio = sm750_dev->pvReg +
+	crtc->cursor.mmio = sm750_dev->pvreg +
 		0x800f0 + (int)crtc->channel * 0x140;
 
 	crtc->cursor.max_h = 64;
@@ -1047,7 +1047,7 @@ static void lynxfb_pci_remove(struct pci_dev *pdev)
 	sm750fb_framebuffer_release(sm750_dev);
 	arch_phys_wc_del(sm750_dev->mtrr.vram);
 
-	iounmap(sm750_dev->pvReg);
+	iounmap(sm750_dev->pvreg);
 	iounmap(sm750_dev->vmem);
 	pci_release_region(pdev, 1);
 	kfree(g_settings);
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index d2c522e67f26..39471d7f2696 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -97,7 +97,7 @@ struct sm750_dev {
 	unsigned long vidreg_start;
 	__u32 vidmem_size;
 	__u32 vidreg_size;
-	void __iomem *pvReg;
+	void __iomem *pvreg;
 	unsigned char __iomem *vmem;
 	/* locks*/
 	spinlock_t slock;
diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
index 34a837fb4b64..d1f021e31a96 100644
--- a/drivers/staging/sm750fb/sm750_hw.c
+++ b/drivers/staging/sm750fb/sm750_hw.c
@@ -23,18 +23,18 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
 	}
 
 	/* now map mmio and vidmem */
-	sm750_dev->pvReg =
+	sm750_dev->pvreg =
 		ioremap(sm750_dev->vidreg_start, sm750_dev->vidreg_size);
-	if (!sm750_dev->pvReg) {
+	if (!sm750_dev->pvreg) {
 		dev_err(&pdev->dev, "mmio failed\n");
 		ret = -EFAULT;
 		goto err_release_region;
 	}
 
-	sm750_dev->accel.dpr_base = sm750_dev->pvReg + DE_BASE_ADDR_TYPE1;
-	sm750_dev->accel.dp_port_base = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1;
+	sm750_dev->accel.dpr_base = sm750_dev->pvreg + DE_BASE_ADDR_TYPE1;
+	sm750_dev->accel.dp_port_base = sm750_dev->pvreg + DE_PORT_ADDR_TYPE1;
 
-	mmio750 = sm750_dev->pvReg;
+	mmio750 = sm750_dev->pvreg;
 	sm750_set_chip_type(sm750_dev->devid, sm750_dev->revid);
 
 	sm750_dev->vidmem_start = pci_resource_start(pdev, 0);
@@ -58,7 +58,7 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
 	return 0;
 
 err_unmap_reg:
-	iounmap(sm750_dev->pvReg);
+	iounmap(sm750_dev->pvreg);
 err_release_region:
 	pci_release_region(pdev, 1);
 	return ret;
-- 
2.34.1

Re: [PATCH] staging: sm750fb: rename pvReg to avoid CamelCase

Posted by Ahmet Sezgin Duran 4 days, 18 hours ago

On 7/20/26 10:48 AM, Olivier Tanoh wrote:
> Fix checkpatch.pl warning regarding the use of CamelCase:
> CHECK: Avoid CamelCase: <pvReg>
> 
> Rename the struct member pvReg to reg across the driver to
> comply with the Linux kernel coding style.
> 
> Signed-off-by: Olivier Tanoh <olivier.tanoh19@gmail.com>
> ---
>   drivers/staging/sm750fb/sm750.c    |  4 ++--
>   drivers/staging/sm750fb/sm750.h    |  2 +-
>   drivers/staging/sm750fb/sm750_hw.c | 12 ++++++------
>   3 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 89c811e0806c..c5f43a364437 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -743,7 +743,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
>   	 * must be set after crtc member initialized
>   	 */
>   	crtc->cursor.offset = crtc->o_screen + crtc->vidmem_size - 1024;
> -	crtc->cursor.mmio = sm750_dev->pvReg +
> +	crtc->cursor.mmio = sm750_dev->pvreg +
>   		0x800f0 + (int)crtc->channel * 0x140;
>   
>   	crtc->cursor.max_h = 64;
> @@ -1047,7 +1047,7 @@ static void lynxfb_pci_remove(struct pci_dev *pdev)
>   	sm750fb_framebuffer_release(sm750_dev);
>   	arch_phys_wc_del(sm750_dev->mtrr.vram);
>   
> -	iounmap(sm750_dev->pvReg);
> +	iounmap(sm750_dev->pvreg);
>   	iounmap(sm750_dev->vmem);
>   	pci_release_region(pdev, 1);
>   	kfree(g_settings);
> diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
> index d2c522e67f26..39471d7f2696 100644
> --- a/drivers/staging/sm750fb/sm750.h
> +++ b/drivers/staging/sm750fb/sm750.h
> @@ -97,7 +97,7 @@ struct sm750_dev {
>   	unsigned long vidreg_start;
>   	__u32 vidmem_size;
>   	__u32 vidreg_size;
> -	void __iomem *pvReg;
> +	void __iomem *pvreg;
>   	unsigned char __iomem *vmem;
>   	/* locks*/
>   	spinlock_t slock;
> diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
> index 34a837fb4b64..d1f021e31a96 100644
> --- a/drivers/staging/sm750fb/sm750_hw.c
> +++ b/drivers/staging/sm750fb/sm750_hw.c
> @@ -23,18 +23,18 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
>   	}
>   
>   	/* now map mmio and vidmem */
> -	sm750_dev->pvReg =
> +	sm750_dev->pvreg =
>   		ioremap(sm750_dev->vidreg_start, sm750_dev->vidreg_size);
> -	if (!sm750_dev->pvReg) {
> +	if (!sm750_dev->pvreg) {
>   		dev_err(&pdev->dev, "mmio failed\n");
>   		ret = -EFAULT;
>   		goto err_release_region;
>   	}
>   
> -	sm750_dev->accel.dpr_base = sm750_dev->pvReg + DE_BASE_ADDR_TYPE1;
> -	sm750_dev->accel.dp_port_base = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1;
> +	sm750_dev->accel.dpr_base = sm750_dev->pvreg + DE_BASE_ADDR_TYPE1;
> +	sm750_dev->accel.dp_port_base = sm750_dev->pvreg + DE_PORT_ADDR_TYPE1;
>   
> -	mmio750 = sm750_dev->pvReg;
> +	mmio750 = sm750_dev->pvreg;
>   	sm750_set_chip_type(sm750_dev->devid, sm750_dev->revid);
>   
>   	sm750_dev->vidmem_start = pci_resource_start(pdev, 0);
> @@ -58,7 +58,7 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
>   	return 0;
>   
>   err_unmap_reg:
> -	iounmap(sm750_dev->pvReg);
> +	iounmap(sm750_dev->pvreg);
>   err_release_region:
>   	pci_release_region(pdev, 1);
>   	return ret;

Does not apply to Greg's staging-testing branch. `pvReg` was already 
renamed to `mmio` before.

Regards,
Ahmet Sezgin Duran