[PATCH] Documentation: wmi: lenovo-wmi-other: Document intentional BIOS misspelling

Yahya Toubali posted 1 patch 5 days, 9 hours ago
Documentation/wmi/devices/lenovo-wmi-other.rst | 4 ++++
1 file changed, 4 insertions(+)
[PATCH] Documentation: wmi: lenovo-wmi-other: Document intentional BIOS misspelling
Posted by Yahya Toubali 5 days, 9 hours ago
The spelling "Minumum" in the FanMinSpeed entry is intentionally kept
as-is because it reflects the actual string returned by the system BIOS.
Add an explanatory note to prevent future redundant spelling-fix submissions.

Suggested-by: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>

Thanks Mark and Jon for the context.

That makes total sense. I dropped the housekeeping typo fix for now to avoid
unnecessary churn, and this v4 keeps the BIOS spelling but adds the explicit
note documenting the firmware quirk as suggested.

---
 Documentation/wmi/devices/lenovo-wmi-other.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/wmi/devices/lenovo-wmi-other.rst b/Documentation/wmi/devices/lenovo-wmi-other.rst
index 01d471156738..f6760f0a6260 100644
--- a/Documentation/wmi/devices/lenovo-wmi-other.rst
+++ b/Documentation/wmi/devices/lenovo-wmi-other.rst
@@ -90,6 +90,10 @@ WMI interface description
 The WMI interface description can be decoded from the embedded binary MOF (bmof)
 data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility:
 
+.. note::
+   The misspelling of "Minumum" in the FanMinSpeed entry below is deliberate
+   and reflects the actual string embedded within the system BIOS.
+
 ::
 
   [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("LENOVO_OTHER_METHOD class"), guid("{dc2a8805-3a8c-41ba-a6f7-092e0089cd3b}")]
-- 
2.55.0
Re: [PATCH] Documentation: wmi: lenovo-wmi-other: Document intentional BIOS misspelling
Posted by Jonathan Corbet 5 days, 9 hours ago
Yahya Toubali <yahya@yahyatoubali.me> writes:

> The spelling "Minumum" in the FanMinSpeed entry is intentionally kept
> as-is because it reflects the actual string returned by the system BIOS.
> Add an explanatory note to prevent future redundant spelling-fix submissions.
>
> Suggested-by: Jonathan Corbet <corbet@lwn.net>
> Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
>
> Thanks Mark and Jon for the context.
>
> That makes total sense. I dropped the housekeeping typo fix for now to avoid
> unnecessary churn, and this v4 keeps the BIOS spelling but adds the explicit
> note documenting the firmware quirk as suggested.

For future reference, text like this does not belong in the changelog.
You can put it below this line:

> ---

...and the maintainer won't have to strip it out when the patch is
applied.

>  Documentation/wmi/devices/lenovo-wmi-other.rst | 4 ++++
>  1 file changed, 4 insertions(+)

One other question: are you writing these patches yourself, or using
some sort of LLM to create them?

Thanks,

jon
Re: [PATCH] Documentation: wmi: lenovo-wmi-other: Document intentional BIOS misspelling
Posted by Yahya Toubali 5 days, 4 hours ago
Hi Jon,

Yes, I used an LLM to help me format the email text because I am still learning how the mailing list process works. 

I will work on my next patches to make sure they are well-structured and follow the proper git mailing list standards.

Thanks for the patience and the explanation,
Yahya
Re: [PATCH] Documentation: wmi: lenovo-wmi-other: Document intentional BIOS misspelling
Posted by Jonathan Corbet 4 days, 14 hours ago
Yahya Toubali <yahya@yahyatoubali.me> writes:

> Hi Jon,
>
> Yes, I used an LLM to help me format the email text because I am still
> learning how the mailing list process works.

Just formatting?

Please review our requirements around LLM use:

  https://docs.kernel.org/process/coding-assistants.html

Thanks,

jon
Re: [PATCH] Documentation: wmi: lenovo-wmi-other: Document intentional BIOS misspelling
Posted by Yahya Toubali 4 days, 6 hours ago
Hi Jon,

Thank you for the link. I have read the policy carefully.

To be completely honest: I used an LLM to identify potential typos and 
whitespace issues across the documentation files, as well as to draft 
the initial commit messages and email syntax. 

I see now why sending automated, low-value patches creates 
unnecessary churn for maintainers. I take full responsibility for 
those submissions. 

Going forward, I will not rely on LLM output for patch generation. Any 
future contributions from me will consist strictly of manual technical 
work and substantive fixes that I thoroughly understand and verify 
myself.

Appreciate your patience and guidance,
Yahya
Re: [PATCH] Documentation: wmi: lenovo-wmi-other: Document intentional BIOS misspelling
Posted by Weijie Yuan 5 days, 4 hours ago
On Sun, Jul 19, 2026 at 11:42:46PM +0100, Yahya Toubali wrote:
> Hi Jon,
> 
> Yes, I used an LLM to help me format the email text because I am still
> learning how the mailing list process works.

I suspect it's not just the format.

> I will work on my next patches to make sure they are well-structured
> and follow the proper git mailing list standards.
> 
> Thanks for the patience and the explanation,
> Yahya

Friendly reminder ;-)

You may get started by wrapping your email to 72 columns first.

Thanks.
Re: [PATCH] Documentation: wmi: lenovo-wmi-other: Document intentional BIOS misspelling
Posted by Weijie Yuan 5 days, 9 hours ago
On Sun, Jul 19, 2026 at 11:44:13AM -0600, Jonathan Corbet wrote:
> One other question: are you writing these patches yourself, or using
> some sort of LLM to create them?

I'm quite afraid and doubtful that our comments might actually be
transformed into his agent's prompt. ;-)

Thanks.