1. Patchew
  2. linux
  3. View series

[PATCH v3] Documentation: fix spelling typos

Yahya Toubali posted 1 patch 6 days, 10 hours ago 
Documentation/core-api/housekeeping.rst        | 2 +-
Documentation/wmi/devices/lenovo-wmi-other.rst | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
[PATCH v3] Documentation: fix spelling typos
Posted by Yahya Toubali 6 days, 10 hours ago 
Fix 'Minumum' -> 'Minimum' in lenovo-wmi-other.rst and
'maintainance' -> 'maintenance' in housekeeping.rst.
These were flagged by checkpatch.

Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
---
 Documentation/core-api/housekeeping.rst        | 2 +-
 Documentation/wmi/devices/lenovo-wmi-other.rst | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/core-api/housekeeping.rst b/Documentation/core-api/housekeeping.rst
index ccb0a88b9cb3..71ba5d86f249 100644
--- a/Documentation/core-api/housekeeping.rst
+++ b/Documentation/core-api/housekeeping.rst
@@ -9,7 +9,7 @@ extreme workloads can't stand, such as in some DPDK usecases.
 
 The kernel work moved away by CPU isolation is commonly described as
 "housekeeping" because it includes ground work that performs cleanups,
-statistics maintainance and actions relying on them, memory release,
+statistics maintenance and actions relying on them, memory release,
 various deferrals etc...
 
 Sometimes housekeeping is just some unbound work (unbound workqueues,
diff --git a/Documentation/wmi/devices/lenovo-wmi-other.rst b/Documentation/wmi/devices/lenovo-wmi-other.rst
index 011054d64eac..65cb78ef285a 100644
--- a/Documentation/wmi/devices/lenovo-wmi-other.rst
+++ b/Documentation/wmi/devices/lenovo-wmi-other.rst
@@ -163,5 +163,5 @@ data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility:
     [WmiDataId(1), read, Description("Mode.")] uint32 NumOfFans;
     [WmiDataId(2), read, Description("Fan ID."), WmiSizeIs("NumOfFans")] uint32 FanId[];
     [WmiDataId(3), read, Description("Maximum Fan Speed."), WmiSizeIs("NumOfFans")] uint32 FanMaxSpeed[];
-    [WmiDataId(4), read, Description("Minumum Fan Speed."), WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
+    [WmiDataId(4), read, Description("Minimum Fan Speed."), WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
   };

base-commit: 1229e2e57a5c2980ccd457b9b53ea0eed5a22ab3
prerequisite-patch-id: c8aee5eb39e3cd6f2b2f28c82163565665288d2a
prerequisite-patch-id: 60ad32e9f0e74902635d7886b97c4225ac8dc5ce
prerequisite-patch-id: 76849a9365b2ef77eae25f4ee42c11f124b1ea0d
-- 
2.55.0
Re: [PATCH v3] Documentation: fix spelling typos
Posted by Mark Pearson 6 days, 1 hour ago 
On Sat, Jul 18, 2026, at 12:56 PM, Yahya Toubali wrote:
> Fix 'Minumum' -> 'Minimum' in lenovo-wmi-other.rst and
> 'maintainance' -> 'maintenance' in housekeeping.rst.
> These were flagged by checkpatch.
>
> Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
> ---
>  Documentation/core-api/housekeeping.rst        | 2 +-
>  Documentation/wmi/devices/lenovo-wmi-other.rst | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/core-api/housekeeping.rst 
> b/Documentation/core-api/housekeeping.rst
> index ccb0a88b9cb3..71ba5d86f249 100644
> --- a/Documentation/core-api/housekeeping.rst
> +++ b/Documentation/core-api/housekeeping.rst
> @@ -9,7 +9,7 @@ extreme workloads can't stand, such as in some DPDK 
> usecases.
> 
>  The kernel work moved away by CPU isolation is commonly described as
>  "housekeeping" because it includes ground work that performs cleanups,
> -statistics maintainance and actions relying on them, memory release,
> +statistics maintenance and actions relying on them, memory release,
>  various deferrals etc...
> 
>  Sometimes housekeeping is just some unbound work (unbound workqueues,
> diff --git a/Documentation/wmi/devices/lenovo-wmi-other.rst 
> b/Documentation/wmi/devices/lenovo-wmi-other.rst
> index 011054d64eac..65cb78ef285a 100644
> --- a/Documentation/wmi/devices/lenovo-wmi-other.rst
> +++ b/Documentation/wmi/devices/lenovo-wmi-other.rst
> @@ -163,5 +163,5 @@ data using the `bmfdec 
> <https://github.com/pali/bmfdec>`_ utility:
>      [WmiDataId(1), read, Description("Mode.")] uint32 NumOfFans;
>      [WmiDataId(2), read, Description("Fan ID."), 
> WmiSizeIs("NumOfFans")] uint32 FanId[];
>      [WmiDataId(3), read, Description("Maximum Fan Speed."), 
> WmiSizeIs("NumOfFans")] uint32 FanMaxSpeed[];
> -    [WmiDataId(4), read, Description("Minumum Fan Speed."), 
> WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
> +    [WmiDataId(4), read, Description("Minimum Fan Speed."), 
> WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
>    };

The minumum fix has been proposed a few times already. It's a miss-spell that comes from the BIOS, so is deliberately wrong.

That being said - I vote we correct it so that we stop getting patches that want to fix it.
In the interests of not seeing it again:

Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>

Mark
Re: [PATCH v3] Documentation: fix spelling typos
Posted by Jonathan Corbet 5 days, 11 hours ago 
"Mark Pearson" <mpearson-lenovo@squebb.ca> writes:

> On Sat, Jul 18, 2026, at 12:56 PM, Yahya Toubali wrote:
>> Fix 'Minumum' -> 'Minimum' in lenovo-wmi-other.rst and
>> 'maintainance' -> 'maintenance' in housekeeping.rst.
>> These were flagged by checkpatch.
>>
>> Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
>> ---
>>  Documentation/core-api/housekeeping.rst        | 2 +-
>>  Documentation/wmi/devices/lenovo-wmi-other.rst | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/core-api/housekeeping.rst 
>> b/Documentation/core-api/housekeeping.rst
>> index ccb0a88b9cb3..71ba5d86f249 100644
>> --- a/Documentation/core-api/housekeeping.rst
>> +++ b/Documentation/core-api/housekeeping.rst
>> @@ -9,7 +9,7 @@ extreme workloads can't stand, such as in some DPDK 
>> usecases.
>> 
>>  The kernel work moved away by CPU isolation is commonly described as
>>  "housekeeping" because it includes ground work that performs cleanups,
>> -statistics maintainance and actions relying on them, memory release,
>> +statistics maintenance and actions relying on them, memory release,
>>  various deferrals etc...
>> 
>>  Sometimes housekeeping is just some unbound work (unbound workqueues,
>> diff --git a/Documentation/wmi/devices/lenovo-wmi-other.rst 
>> b/Documentation/wmi/devices/lenovo-wmi-other.rst
>> index 011054d64eac..65cb78ef285a 100644
>> --- a/Documentation/wmi/devices/lenovo-wmi-other.rst
>> +++ b/Documentation/wmi/devices/lenovo-wmi-other.rst
>> @@ -163,5 +163,5 @@ data using the `bmfdec 
>> <https://github.com/pali/bmfdec>`_ utility:
>>      [WmiDataId(1), read, Description("Mode.")] uint32 NumOfFans;
>>      [WmiDataId(2), read, Description("Fan ID."), 
>> WmiSizeIs("NumOfFans")] uint32 FanId[];
>>      [WmiDataId(3), read, Description("Maximum Fan Speed."), 
>> WmiSizeIs("NumOfFans")] uint32 FanMaxSpeed[];
>> -    [WmiDataId(4), read, Description("Minumum Fan Speed."), 
>> WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
>> +    [WmiDataId(4), read, Description("Minimum Fan Speed."), 
>> WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
>>    };
>
> The minumum fix has been proposed a few times already. It's a miss-spell that comes from the BIOS, so is deliberately wrong.
>
> That being said - I vote we correct it so that we stop getting patches that want to fix it.
> In the interests of not seeing it again:

Instead, why not add a line to the file saying that the BIOS actually
behaves that way?

Thanks,

jon
[PATCH] Documentation: wmi: lenovo-wmi-other: Document intentional BIOS misspelling
Posted by Yahya Toubali 5 days, 10 hours ago 
The spelling "Minumum" in the FanMinSpeed entry is intentionally kept
as-is because it reflects the actual string returned by the system BIOS.
Add an explanatory note to prevent future redundant spelling-fix submissions.

Suggested-by: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>

Thanks Mark and Jon for the context.

That makes total sense. I dropped the housekeeping typo fix for now to avoid
unnecessary churn, and this v4 keeps the BIOS spelling but adds the explicit
note documenting the firmware quirk as suggested.

---
 Documentation/wmi/devices/lenovo-wmi-other.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/wmi/devices/lenovo-wmi-other.rst b/Documentation/wmi/devices/lenovo-wmi-other.rst
index 01d471156738..f6760f0a6260 100644
--- a/Documentation/wmi/devices/lenovo-wmi-other.rst
+++ b/Documentation/wmi/devices/lenovo-wmi-other.rst
@@ -90,6 +90,10 @@ WMI interface description
 The WMI interface description can be decoded from the embedded binary MOF (bmof)
 data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility:
 
+.. note::
+   The misspelling of "Minumum" in the FanMinSpeed entry below is deliberate
+   and reflects the actual string embedded within the system BIOS.
+
 ::
 
   [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("LENOVO_OTHER_METHOD class"), guid("{dc2a8805-3a8c-41ba-a6f7-092e0089cd3b}")]
-- 
2.55.0
Re: [PATCH] Documentation: wmi: lenovo-wmi-other: Document intentional BIOS misspelling
Posted by Jonathan Corbet 5 days, 10 hours ago 
Yahya Toubali <yahya@yahyatoubali.me> writes:

> The spelling "Minumum" in the FanMinSpeed entry is intentionally kept
> as-is because it reflects the actual string returned by the system BIOS.
> Add an explanatory note to prevent future redundant spelling-fix submissions.
>
> Suggested-by: Jonathan Corbet <corbet@lwn.net>
> Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
>
> Thanks Mark and Jon for the context.
>
> That makes total sense. I dropped the housekeeping typo fix for now to avoid
> unnecessary churn, and this v4 keeps the BIOS spelling but adds the explicit
> note documenting the firmware quirk as suggested.

For future reference, text like this does not belong in the changelog.
You can put it below this line:

> ---

...and the maintainer won't have to strip it out when the patch is
applied.

>  Documentation/wmi/devices/lenovo-wmi-other.rst | 4 ++++
>  1 file changed, 4 insertions(+)

One other question: are you writing these patches yourself, or using
some sort of LLM to create them?

Thanks,

jon
Re: [PATCH] Documentation: wmi: lenovo-wmi-other: Document intentional BIOS misspelling
Posted by Yahya Toubali 5 days, 5 hours ago 
Hi Jon,

Yes, I used an LLM to help me format the email text because I am still learning how the mailing list process works. 

I will work on my next patches to make sure they are well-structured and follow the proper git mailing list standards.

Thanks for the patience and the explanation,
Yahya
Re: [PATCH] Documentation: wmi: lenovo-wmi-other: Document intentional BIOS misspelling
Posted by Jonathan Corbet 4 days, 14 hours ago 
Yahya Toubali <yahya@yahyatoubali.me> writes:

> Hi Jon,
>
> Yes, I used an LLM to help me format the email text because I am still
> learning how the mailing list process works.

Just formatting?

Please review our requirements around LLM use:

  https://docs.kernel.org/process/coding-assistants.html

Thanks,

jon
Re: [PATCH] Documentation: wmi: lenovo-wmi-other: Document intentional BIOS misspelling
Posted by Yahya Toubali 4 days, 6 hours ago 
Hi Jon,

Thank you for the link. I have read the policy carefully.

To be completely honest: I used an LLM to identify potential typos and 
whitespace issues across the documentation files, as well as to draft 
the initial commit messages and email syntax. 

I see now why sending automated, low-value patches creates 
unnecessary churn for maintainers. I take full responsibility for 
those submissions. 

Going forward, I will not rely on LLM output for patch generation. Any 
future contributions from me will consist strictly of manual technical 
work and substantive fixes that I thoroughly understand and verify 
myself.

Appreciate your patience and guidance,
Yahya
Re: [PATCH] Documentation: wmi: lenovo-wmi-other: Document intentional BIOS misspelling
Posted by Weijie Yuan 5 days, 4 hours ago 
On Sun, Jul 19, 2026 at 11:42:46PM +0100, Yahya Toubali wrote:
> Hi Jon,
> 
> Yes, I used an LLM to help me format the email text because I am still
> learning how the mailing list process works.

I suspect it's not just the format.

> I will work on my next patches to make sure they are well-structured
> and follow the proper git mailing list standards.
> 
> Thanks for the patience and the explanation,
> Yahya

Friendly reminder ;-)

You may get started by wrapping your email to 72 columns first.

Thanks.
Re: [PATCH] Documentation: wmi: lenovo-wmi-other: Document intentional BIOS misspelling
Posted by Weijie Yuan 5 days, 9 hours ago 
On Sun, Jul 19, 2026 at 11:44:13AM -0600, Jonathan Corbet wrote:
> One other question: are you writing these patches yourself, or using
> some sort of LLM to create them?

I'm quite afraid and doubtful that our comments might actually be
transformed into his agent's prompt. ;-)

Thanks.

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.