[PATCH] phy: qcom: m31-eusb2: Fix return value of init call

Krishna Kurapati posted 1 patch 6 days, 18 hours ago
drivers/phy/qualcomm/phy-qcom-m31-eusb2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] phy: qcom: m31-eusb2: Fix return value of init call
Posted by Krishna Kurapati 6 days, 18 hours ago
The init call currently returns success irrespective of any failures
during repeater init or clock enablement. Return appropriate error value
in the init call failure path.

Fixes: 9c8504861cc4 ("phy: qcom: Add M31 based eUSB2 PHY driver")
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
 drivers/phy/qualcomm/phy-qcom-m31-eusb2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
index 0bec8657149c..275df38256de 100644
--- a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
+++ b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
@@ -221,7 +221,7 @@ static int m31eusb2_phy_init(struct phy *uphy)
 disable_vreg:
 	regulator_bulk_disable(M31_EUSB_NUM_VREGS, phy->vregs);
 
-	return 0;
+	return ret;
 }
 
 static int m31eusb2_phy_exit(struct phy *uphy)

---
base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
change-id: 20260718-m31-eusb2-fix-666cf8c5a72c

Best regards,
--  
Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Re: [PATCH] phy: qcom: m31-eusb2: Fix return value of init call
Posted by Vinod Koul 4 days, 16 hours ago
On Sat, 18 Jul 2026 15:01:31 +0530, Krishna Kurapati wrote:
> The init call currently returns success irrespective of any failures
> during repeater init or clock enablement. Return appropriate error value
> in the init call failure path.
> 
> 

Applied, thanks!

[1/1] phy: qcom: m31-eusb2: Fix return value of init call
      commit: 361f533a2dce2c2841fe4dc0c9d85a67117edf95

Best regards,
-- 
~Vinod