.../devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 6 ++++++ 1 file changed, 6 insertions(+)
The DesignWare I3C master IP supports a core reset input, but the
binding is missing the corresponding reset description.
Document the reset property and name in the binding. Keep the reset
optional because the reset line is integration-specific..
Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>
---
Note:
The DesignWare I3C driver support was added by
1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP").
The original Synopsys DesignWare I3C binding was added by
116e246a8bcd ("dt-binding: i3c: Document Synopsys DesignWare I3C"),
but it did not document the optional core reset.
---
.../devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
index e803457d3f55..822faf8d221b 100644
--- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
+++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
@@ -38,6 +38,12 @@ properties:
interrupts:
maxItems: 1
+ resets:
+ maxItems: 1
+
+ reset-names:
+ const: core_rst
+
power-domains:
maxItems: 1
base-commit: a13c140cc289c0b7b3770bce5b3ad42ab35074aa
--
2.49.1
On 17/07/2026 12:58, Shubham Patil wrote:
> The DesignWare I3C master IP supports a core reset input, but the
> binding is missing the corresponding reset description.
>
> Document the reset property and name in the binding. Keep the reset
> optional because the reset line is integration-specific..
>
> Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>
> ---
> Note:
> The DesignWare I3C driver support was added by
> 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP").
>
> The original Synopsys DesignWare I3C binding was added by
> 116e246a8bcd ("dt-binding: i3c: Document Synopsys DesignWare I3C"),
> but it did not document the optional core reset.
> ---
> .../devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> index e803457d3f55..822faf8d221b 100644
> --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> @@ -38,6 +38,12 @@ properties:
> interrupts:
> maxItems: 1
>
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + const: core_rst
Drop the names, pretty redundant, and fix the driver. Sneaking ABI is a
poor excuse, IMO, to keep discouraged names.
Best regards,
Krzysztof
On Fri, Jul 17, 2026 at 01:33:15PM +0200, Krzysztof Kozlowski wrote:
> On 17/07/2026 12:58, Shubham Patil wrote:
> > The DesignWare I3C master IP supports a core reset input, but the
> > binding is missing the corresponding reset description.
> >
> > Document the reset property and name in the binding. Keep the reset
> > optional because the reset line is integration-specific..
> >
> > Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>
> > ---
> > Note:
> > The DesignWare I3C driver support was added by
> > 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP").
> >
> > The original Synopsys DesignWare I3C binding was added by
> > 116e246a8bcd ("dt-binding: i3c: Document Synopsys DesignWare I3C"),
> > but it did not document the optional core reset.
> > ---
> > .../devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> > index e803457d3f55..822faf8d221b 100644
> > --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> > +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> > @@ -38,6 +38,12 @@ properties:
> > interrupts:
> > maxItems: 1
> >
> > + resets:
> > + maxItems: 1
> > +
> > + reset-names:
> > + const: core_rst
>
> Drop the names, pretty redundant, and fix the driver. Sneaking ABI is a
> poor excuse, IMO, to keep discouraged names.
While fixing the driver, the clock names sashiko pointed out can be
fixed too.
Rob
© 2016 - 2026 Red Hat, Inc.