[PATCH 00/13] iio: Remove redundant error messages on IRQ request failure

Pan Chuang posted 13 patches 1 week ago
There is a newer version of this series
drivers/iio/accel/adxl355_core.c                   | 3 +--
drivers/iio/accel/adxl367.c                        | 2 +-
drivers/iio/accel/bma180.c                         | 4 +---
drivers/iio/accel/bma220_core.c                    | 3 +--
drivers/iio/accel/bma400_core.c                    | 3 +--
drivers/iio/accel/kionix-kx022a.c                  | 2 +-
drivers/iio/accel/mma9551.c                        | 4 +---
drivers/iio/accel/mma9553.c                        | 5 +----
drivers/iio/accel/msa311.c                         | 2 +-
drivers/iio/accel/mxc4005.c                        | 5 +----
drivers/iio/accel/stk8312.c                        | 5 +----
drivers/iio/accel/stk8ba50.c                       | 5 +----
drivers/iio/addac/ad74413r.c                       | 2 +-
drivers/iio/chemical/ccs811.c                      | 4 +---
drivers/iio/chemical/ens160_core.c                 | 2 +-
drivers/iio/chemical/scd30_core.c                  | 2 +-
drivers/iio/common/st_sensors/st_sensors_trigger.c | 4 +---
drivers/iio/gyro/adxrs290.c                        | 3 +--
drivers/iio/health/afe4403.c                       | 4 +---
drivers/iio/health/afe4404.c                       | 4 +---
drivers/iio/health/max30100.c                      | 4 +---
drivers/iio/health/max30102.c                      | 4 +---
drivers/iio/humidity/hdc3020.c                     | 3 +--
drivers/iio/humidity/hts221_buffer.c               | 5 +----
drivers/iio/imu/bmi270/bmi270_core.c               | 2 +-
drivers/iio/imu/bmi323/bmi323_core.c               | 2 +-
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c       | 5 +----
drivers/iio/light/adux1020.c                       | 4 +---
drivers/iio/light/apds9160.c                       | 7 ++-----
drivers/iio/light/apds9300.c                       | 4 +---
drivers/iio/light/apds9306.c                       | 3 +--
drivers/iio/light/apds9960.c                       | 4 +---
drivers/iio/light/bh1745.c                         | 3 +--
drivers/iio/light/cm3605.c                         | 4 +---
drivers/iio/light/gp2ap002.c                       | 4 +---
drivers/iio/light/ltr390.c                         | 3 +--
drivers/iio/light/ltr501.c                         | 5 +----
drivers/iio/light/opt4060.c                        | 2 +-
drivers/iio/light/rpr0521.c                        | 5 +----
drivers/iio/light/si1145.c                         | 4 +---
drivers/iio/light/st_uvis25_core.c                 | 5 +----
drivers/iio/light/stk3310.c                        | 5 +----
drivers/iio/light/tsl2563.c                        | 2 +-
drivers/iio/light/tsl2772.c                        | 5 +----
drivers/iio/light/vcnl4035.c                       | 3 ---
drivers/iio/light/veml6030.c                       | 4 +---
drivers/iio/light/vl6180.c                         | 2 +-
drivers/iio/magnetometer/ak8974.c                  | 5 +----
drivers/iio/magnetometer/rm3100-core.c             | 4 +---
drivers/iio/pressure/bmp280-core.c                 | 3 +--
drivers/iio/pressure/dlhl60d.c                     | 4 +---
drivers/iio/pressure/rohm-bm1390.c                 | 2 +-
drivers/iio/pressure/zpa2326.c                     | 5 +----
drivers/iio/proximity/as3935.c                     | 4 +---
drivers/iio/proximity/d3323aa.c                    | 2 +-
drivers/iio/proximity/hx9023s.c                    | 2 +-
drivers/iio/proximity/irsd200.c                    | 2 +-
drivers/iio/proximity/mb1232.c                     | 4 +---
drivers/iio/proximity/srf04.c                      | 4 +---
drivers/iio/proximity/sx_common.c                  | 2 +-
drivers/iio/proximity/vcnl3020.c                   | 6 +-----
drivers/iio/proximity/vl53l0x-i2c.c                | 4 +---
drivers/iio/temperature/ltc2983.c                  | 2 +-
drivers/iio/temperature/tmp007.c                   | 4 +---
64 files changed, 64 insertions(+), 166 deletions(-)
[PATCH 00/13] iio: Remove redundant error messages on IRQ request failure
Posted by Pan Chuang 1 week ago
Commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()") added automatic error logging to
devm_request_threaded_irq() and devm_request_any_context_irq()
via the new devm_request_result() helper, which prints device
name, IRQ number, handler functions, and error code on failure.

Since devm_request_irq() is a static inline wrapper around
devm_request_threaded_irq(), it also benefits from this
automatic logging.

Remove the now-redundant dev_err() and dev_err_probe() calls
in iio drivers that follow these devm_request_*_irq()
functions, as the core now provides more detailed diagnostic
information on failure.

Pan Chuang (13):
  iio: accel: Remove redundant dev_err()/dev_err_probe()
  iio: addac: Remove redundant dev_err_probe()
  iio: chemical: Remove redundant dev_err()/dev_err_probe()
  iio: common: Remove redundant dev_err()
  iio: gyro: Remove redundant dev_err_probe()
  iio: health: Remove redundant dev_err()
  iio: humidity: Remove redundant dev_err()/dev_err_probe()
  iio: imu: Remove redundant dev_err()/dev_err_probe()
  iio: magnetometer: Remove redundant dev_err()
  iio: pressure: Remove redundant dev_err()/dev_err_probe()
  iio: proximity: Remove redundant dev_err()/dev_err_probe()
  iio: light: Remove redundant dev_err()/dev_err_probe()
  iio: temperature: Remove redundant dev_err()/dev_err_probe()

 drivers/iio/accel/adxl355_core.c                   | 3 +--
 drivers/iio/accel/adxl367.c                        | 2 +-
 drivers/iio/accel/bma180.c                         | 4 +---
 drivers/iio/accel/bma220_core.c                    | 3 +--
 drivers/iio/accel/bma400_core.c                    | 3 +--
 drivers/iio/accel/kionix-kx022a.c                  | 2 +-
 drivers/iio/accel/mma9551.c                        | 4 +---
 drivers/iio/accel/mma9553.c                        | 5 +----
 drivers/iio/accel/msa311.c                         | 2 +-
 drivers/iio/accel/mxc4005.c                        | 5 +----
 drivers/iio/accel/stk8312.c                        | 5 +----
 drivers/iio/accel/stk8ba50.c                       | 5 +----
 drivers/iio/addac/ad74413r.c                       | 2 +-
 drivers/iio/chemical/ccs811.c                      | 4 +---
 drivers/iio/chemical/ens160_core.c                 | 2 +-
 drivers/iio/chemical/scd30_core.c                  | 2 +-
 drivers/iio/common/st_sensors/st_sensors_trigger.c | 4 +---
 drivers/iio/gyro/adxrs290.c                        | 3 +--
 drivers/iio/health/afe4403.c                       | 4 +---
 drivers/iio/health/afe4404.c                       | 4 +---
 drivers/iio/health/max30100.c                      | 4 +---
 drivers/iio/health/max30102.c                      | 4 +---
 drivers/iio/humidity/hdc3020.c                     | 3 +--
 drivers/iio/humidity/hts221_buffer.c               | 5 +----
 drivers/iio/imu/bmi270/bmi270_core.c               | 2 +-
 drivers/iio/imu/bmi323/bmi323_core.c               | 2 +-
 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c       | 5 +----
 drivers/iio/light/adux1020.c                       | 4 +---
 drivers/iio/light/apds9160.c                       | 7 ++-----
 drivers/iio/light/apds9300.c                       | 4 +---
 drivers/iio/light/apds9306.c                       | 3 +--
 drivers/iio/light/apds9960.c                       | 4 +---
 drivers/iio/light/bh1745.c                         | 3 +--
 drivers/iio/light/cm3605.c                         | 4 +---
 drivers/iio/light/gp2ap002.c                       | 4 +---
 drivers/iio/light/ltr390.c                         | 3 +--
 drivers/iio/light/ltr501.c                         | 5 +----
 drivers/iio/light/opt4060.c                        | 2 +-
 drivers/iio/light/rpr0521.c                        | 5 +----
 drivers/iio/light/si1145.c                         | 4 +---
 drivers/iio/light/st_uvis25_core.c                 | 5 +----
 drivers/iio/light/stk3310.c                        | 5 +----
 drivers/iio/light/tsl2563.c                        | 2 +-
 drivers/iio/light/tsl2772.c                        | 5 +----
 drivers/iio/light/vcnl4035.c                       | 3 ---
 drivers/iio/light/veml6030.c                       | 4 +---
 drivers/iio/light/vl6180.c                         | 2 +-
 drivers/iio/magnetometer/ak8974.c                  | 5 +----
 drivers/iio/magnetometer/rm3100-core.c             | 4 +---
 drivers/iio/pressure/bmp280-core.c                 | 3 +--
 drivers/iio/pressure/dlhl60d.c                     | 4 +---
 drivers/iio/pressure/rohm-bm1390.c                 | 2 +-
 drivers/iio/pressure/zpa2326.c                     | 5 +----
 drivers/iio/proximity/as3935.c                     | 4 +---
 drivers/iio/proximity/d3323aa.c                    | 2 +-
 drivers/iio/proximity/hx9023s.c                    | 2 +-
 drivers/iio/proximity/irsd200.c                    | 2 +-
 drivers/iio/proximity/mb1232.c                     | 4 +---
 drivers/iio/proximity/srf04.c                      | 4 +---
 drivers/iio/proximity/sx_common.c                  | 2 +-
 drivers/iio/proximity/vcnl3020.c                   | 6 +-----
 drivers/iio/proximity/vl53l0x-i2c.c                | 4 +---
 drivers/iio/temperature/ltc2983.c                  | 2 +-
 drivers/iio/temperature/tmp007.c                   | 4 +---
 64 files changed, 64 insertions(+), 166 deletions(-)

-- 
2.34.1
Re: [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure
Posted by Andy Shevchenko 1 week ago
On Fri, Jul 17, 2026 at 05:42:23PM +0800, Pan Chuang wrote:
> Commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()") added automatic error logging to
> devm_request_threaded_irq() and devm_request_any_context_irq()
> via the new devm_request_result() helper, which prints device
> name, IRQ number, handler functions, and error code on failure.
> 
> Since devm_request_irq() is a static inline wrapper around
> devm_request_threaded_irq(), it also benefits from this
> automatic logging.
> 
> Remove the now-redundant dev_err() and dev_err_probe() calls
> in iio drivers that follow these devm_request_*_irq()
> functions, as the core now provides more detailed diagnostic
> information on failure.

Same comment as per your other series.

While at it drop all these ' != 0' and ' < 0' noise in the conditionals.
With that being done, feel free to add my
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko