[PATCH] extcon: intel-mrfld: Remove redundant dev_err_probe()

Pan Chuang posted 1 patch 1 week, 1 day ago
drivers/extcon/extcon-intel-mrfld.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] extcon: intel-mrfld: Remove redundant dev_err_probe()
Posted by Pan Chuang 1 week, 1 day ago
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err_probe() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/extcon/extcon-intel-mrfld.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/extcon/extcon-intel-mrfld.c b/drivers/extcon/extcon-intel-mrfld.c
index 7246d704fa3d..e23a83796677 100644
--- a/drivers/extcon/extcon-intel-mrfld.c
+++ b/drivers/extcon/extcon-intel-mrfld.c
@@ -223,7 +223,7 @@ static int mrfld_extcon_probe(struct platform_device *pdev)
 					IRQF_ONESHOT | IRQF_SHARED, pdev->name,
 					data);
 	if (ret)
-		return dev_err_probe(dev, ret, "can't register IRQ handler\n");
+		return ret;
 
 	ret = regmap_read(regmap, BCOVE_ID, &id);
 	if (ret)
-- 
2.34.1
Re: [PATCH] extcon: intel-mrfld: Remove redundant dev_err_probe()
Posted by Andy Shevchenko 1 week ago
On Fri, Jul 17, 2026 at 10:17:21AM +0800, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err_probe() calls.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko