[PATCH] soundwire: qcom: Remove redundant dev_err()

Pan Chuang posted 1 patch 1 week, 2 days ago
drivers/soundwire/qcom.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
[PATCH] soundwire: qcom: Remove redundant dev_err()
Posted by Pan Chuang 1 week, 2 days ago
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/soundwire/qcom.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index 3562802f4204..934b4053b1e3 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -1646,10 +1646,8 @@ static int qcom_swrm_probe(struct platform_device *pdev)
 					IRQF_TRIGGER_RISING |
 					IRQF_ONESHOT,
 					"soundwire", ctrl);
-	if (ret) {
-		dev_err(dev, "Failed to request soundwire irq\n");
+	if (ret)
 		goto err_clk;
-	}
 
 	ctrl->wake_irq = of_irq_get(dev->of_node, 1);
 	if (ctrl->wake_irq > 0) {
@@ -1657,10 +1655,8 @@ static int qcom_swrm_probe(struct platform_device *pdev)
 						qcom_swrm_wake_irq_handler,
 						IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
 						"swr_wake_irq", ctrl);
-		if (ret) {
-			dev_err(dev, "Failed to request soundwire wake irq\n");
+		if (ret)
 			goto err_init;
-		}
 	}
 
 	ctrl->bus.controller_id = -1;
-- 
2.34.1